From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shannon Nelson Subject: Re: [PATCH net-next 0/2] fixes for ipsec selftests Date: Wed, 20 Jun 2018 15:26:08 -0700 Message-ID: References: <1529473363-4036-1-git-send-email-shannon.nelson@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Networking , David Miller To: Anders Roxell Return-path: Received: from aserp2130.oracle.com ([141.146.126.79]:40934 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933472AbeFTW0R (ORCPT ); Wed, 20 Jun 2018 18:26:17 -0400 In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 6/20/2018 12:09 PM, Anders Roxell wrote: > On Wed, 20 Jun 2018 at 07:42, Shannon Nelson wrote: >> >> A couple of bad behaviors in the ipsec selftest were pointed out >> by Anders Roxell and are addressed here. >> >> Shannon Nelson (2): >> selftests: rtnetlink: hide complaint from terminated monitor >> selftests: rtnetlink: use a local IP address for IPsec tests >> >> tools/testing/selftests/net/rtnetlink.sh | 11 +++++++---- >> 1 file changed, 7 insertions(+), 4 deletions(-) >> >> -- >> 2.7.4 >> > > Hi Shannon, > > With this patches applied and my config patch. > > I still get this error when I run the ipsec test: > > FAIL: can't add fou port 7777, skipping test > RTNETLINK answers: Operation not supported > FAIL: can't add macsec interface, skipping test > RTNETLINK answers: Protocol not supported > RTNETLINK answers: No such process > RTNETLINK answers: No such process > FAIL: ipsec One of the odd things I noticed about this script is that there really aren't any diagnosis messages, just PASS or FAIL. I followed this custom when I added the ipsec tests, but I think this is something that should change so we can get some idea of what breaks. I'm curious about the "RTNETLINK answers" messages and where they might be coming from, especially "RTNETLINK answers: Protocol not supported". What version of iproute2 are you using? Is it older than iproute2-ss130716? What distro and kernel are you running? What are the XFRM and AES settings in your kernel config - what is the output from egrep -i "xfrm|_aes" .config I did also notice that the ipsec test should set ret=0 at its start. Can you either add this or comment out all the other tests in kci_test_rtnl() so that only the kci_test_ipsec is run and send me the output? Thanks, sln > > Can you please cc the kselftest list when sending patches to > tools/testing/selftests/ ? > > Cheers, > Anders >