From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Ariel Levkovich <lariel@mellanox.com>,
netdev@vger.kernel.org, kuba@kernel.org,
xiyou.wangcong@gmail.com, ast@kernel.org, daniel@iogearbox.net
Subject: Re: [PATCH net-next v2 0/3] ] TC datapath hash api
Date: Fri, 7 Aug 2020 06:41:29 -0400 [thread overview]
Message-ID: <cd59f9e3-1bc3-0e2b-3c77-52373567bb73@mojatatu.com> (raw)
In-Reply-To: <c4d819f5-1a0f-2a12-6a4d-ce523f51c571@mojatatu.com>
On 2020-07-10 8:04 a.m., Jamal Hadi Salim wrote:
> On 2020-07-09 8:19 a.m., Jiri Pirko wrote:
>> Thu, Jul 09, 2020 at 01:00:26PM CEST, jhs@mojatatu.com wrote:
>>>
>>> Main point is: classifying based on hash(and for that
>>> matter any other metadata like mark) is needed as a general
>>> utility for the system and should not be only available for
>>> flower. The one big reason we allow all kinds of classifiers
>>> in tc is in the name of "do one thing and do it well".
>>
>> Sure. That classifier can exist, no problem. At the same time, flower
>> can match on it as well. There are already multiple examples of
>> classifiers matching on the same thing. I don't see any problem there.
>>
>
> I keep pointing to the issues and we keep circling back
> to your desire to add it to flower. I emphatize with the
> desire to have flower as a one stop shop for all things classification
> but this is at the expense of other classifiers. I too need this for
> offloading as well as getting the RSS proper feature i described.ets
> make progress.
> You go ahead - i will submit a version to add it as a separate
> hash classifier.
>
Some cycles opened up - I will work on this in the next day or
two now that your patches are in...
cheers,
jamal
prev parent reply other threads:[~2020-08-07 10:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 18:47 [PATCH net-next v2 0/3] ] TC datapath hash api Ariel Levkovich
2020-07-01 18:47 ` [PATCH net-next v2 1/3] net/sched: Introduce action hash Ariel Levkovich
2020-07-01 22:20 ` kernel test robot
2020-07-02 20:52 ` Cong Wang
2020-07-01 18:47 ` [PATCH net-next v2 2/3] net/flow_dissector: add packet hash dissection Ariel Levkovich
2020-07-01 18:47 ` [PATCH net-next v2 3/3] net/sched: cls_flower: Add hash info to flow classification Ariel Levkovich
2020-07-03 11:22 ` [PATCH net-next v2 0/3] ] TC datapath hash api Jamal Hadi Salim
2020-07-05 17:26 ` Ariel Levkovich
2020-07-05 21:50 ` Jamal Hadi Salim
2020-07-06 0:28 ` Cong Wang
2020-07-09 13:52 ` Ariel Levkovich
2020-07-06 0:23 ` Cong Wang
2020-07-07 10:05 ` Jiri Pirko
2020-07-08 13:54 ` Jamal Hadi Salim
2020-07-08 14:45 ` Jiri Pirko
2020-07-09 11:00 ` Jamal Hadi Salim
2020-07-09 12:19 ` Jiri Pirko
2020-07-10 12:04 ` Jamal Hadi Salim
2020-08-07 10:41 ` Jamal Hadi Salim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd59f9e3-1bc3-0e2b-3c77-52373567bb73@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=lariel@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox