Netdev List
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: 'Ulf Hansson' <ulf.hansson@linaro.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: "pizza@shaftnet.org" <pizza@shaftnet.org>,
	Arnd Bergmann <arnd@arndb.de>, Kalle Valo <kvalo@codeaurora.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC PATCH] cw1200: use kmalloc() allocation instead of stack
Date: Wed, 30 Jun 2021 16:08:05 +0000	[thread overview]
Message-ID: <cd6360a4247e47cdb819343a05b70d05@AcuMS.aculab.com> (raw)
In-Reply-To: <CAPDyKFo6AVGq5Q9bRKPjypRMxisLf0nZWLtSeARGO-3kO7=+zQ@mail.gmail.com>

From: Ulf Hansson
> Sent: 30 June 2021 11:03
...
> > It turns out that if CONFIG_VMAP_STACK is enabled and src or dst is
> > memory allocated on stack, SDIO operations fail due to invalid memory
> > address conversion:
...
> > Fix that by using kmalloc() allocated memory for read/write 16/32
> > funtions.

Could a field be added to 'struct cw1200_common'
that the functions could use as a bounce buffer?

ISTM that is DMA are being done there must be some
serialisation in there somewhere that will stop
concurrent accesses.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

      parent reply	other threads:[~2021-06-30 16:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22 20:23 [RFC PATCH] cw1200: use kmalloc() allocation instead of stack Jernej Skrabec
2021-06-22 20:30 ` Arnd Bergmann
2021-06-30  9:55   ` Ulf Hansson
2021-06-30 11:30     ` Arnd Bergmann
2021-06-30 12:03       ` Ulf Hansson
2021-06-30 12:21         ` Arnd Bergmann
2021-06-30 10:03 ` Ulf Hansson
2021-06-30 10:09   ` Jernej Škrabec
2021-06-30 12:00     ` Ulf Hansson
2021-06-30 16:08   ` David Laight [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd6360a4247e47cdb819343a05b70d05@AcuMS.aculab.com \
    --to=david.laight@aculab.com \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=jernej.skrabec@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pizza@shaftnet.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox