From: "Andrew Victor" <avictor.za@gmail.com>
To: "Marc Pignat" <marc.pignat@hevs.ch>
Cc: linux-arm-kernel@lists.arm.linux.org.uk, netdev@vger.kernel.org,
linux@maxim.org.za
Subject: Re: [PATCH] at91_ether: late collistions are counted twice
Date: Thu, 8 May 2008 21:40:21 +0200 [thread overview]
Message-ID: <cd73a99e0805081240x4e697c5aq1c768ff888ce7d13@mail.gmail.com> (raw)
In-Reply-To: <200805081739.02489.marc.pignat@hevs.ch>
hi,
> According to the at91rm9200 datasheet, table 36-6, late collisions
> (AT91_EMAC_LCOL) are already counted in the collision register (in scol, mcol or
> ecol , depending on the type of error).
>
> So don't count them twice in stats.collisions.
>
> Signed-off-by: Marc Pignat <marc.pignat@hevs.ch>
Acked-by: Andrew Victor <linux@maxim.org.za>
Regards,
Andrew Victor
prev parent reply other threads:[~2008-05-08 19:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-08 15:39 [PATCH] at91_ether: late collistions are counted twice Marc Pignat
2008-05-08 19:40 ` Andrew Victor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd73a99e0805081240x4e697c5aq1c768ff888ce7d13@mail.gmail.com \
--to=avictor.za@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux@maxim.org.za \
--cc=marc.pignat@hevs.ch \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).