From: "Arinzon, David" <darinzon@amazon.com>
To: Simon Horman <horms@kernel.org>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
"Machulsky, Zorik" <zorik@amazon.com>,
"Matushevsky, Alexander" <matua@amazon.com>,
"Bshara, Saeed" <saeedb@amazon.com>,
"Wilson, Matt" <msw@amazon.com>,
"Liguori, Anthony" <aliguori@amazon.com>,
"Bshara, Nafea" <nafea@amazon.com>,
"Schmeilin, Evgeny" <evgenys@amazon.com>,
"Belgazal, Netanel" <netanel@amazon.com>,
"Saidi, Ali" <alisaidi@amazon.com>,
"Herrenschmidt, Benjamin" <benh@amazon.com>,
"Kiyanovski, Arthur" <akiyano@amazon.com>,
"Dagan, Noam" <ndagan@amazon.com>,
"Bernstein, Amit" <amitbern@amazon.com>,
"Agroskin, Shay" <shayagr@amazon.com>,
"Abboud, Osama" <osamaabb@amazon.com>,
"Ostrovsky, Evgeny" <evostrov@amazon.com>,
"Tabachnik, Ofir" <ofirt@amazon.com>,
"Machnikowski, Maciek" <maciek@machnikowski.net>
Subject: RE: [PATCH v1 net-next 1/3] net: ena: Add PHC support in the ENA driver
Date: Tue, 22 Oct 2024 14:22:30 +0000 [thread overview]
Message-ID: <cd78a56636034961997214e418747d77@amazon.com> (raw)
In-Reply-To: <20241021163955.GL402847@kernel.org>
> > The ENA driver will be extended to support the new PHC feature using
> > ptp_clock interface [1]. this will provide timestamp reference for
> > user space to allow measuring time offset between the PHC and the
> > system clock in order to achieve nanosecond accuracy.
> >
> > [1] - https://www.kernel.org/doc/html/latest/driver-api/ptp.html
> >
> > Signed-off-by: Amit Bernstein <amitbern@amazon.com>
> > Signed-off-by: David Arinzon <darinzon@amazon.com>
>
> Hi David,
>
> As it looks like there will be a v2 anyway, please consider running this series,
> and in particular this patch, through:
>
> ./scripts/checkpatch.pl --strict --max-line-length=80 --codespell
>
> And please fix warnings it emits where that can be done without reducing
> readability and clarity. E.g. please don't split string literals across more than
> one line just to make lines short.
>
> Thanks!
Thanks Simon,
We'll resolve the issues in the next patchset.
next prev parent reply other threads:[~2024-10-22 14:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 5:20 [PATCH v1 net-next 0/3] PHC support in ENA driver David Arinzon
2024-10-21 5:20 ` [PATCH v1 net-next 1/3] net: ena: Add PHC support in the " David Arinzon
2024-10-21 16:39 ` Simon Horman
2024-10-22 14:22 ` Arinzon, David [this message]
2024-10-21 5:20 ` [PATCH v1 net-next 2/3] net: ena: PHC silent reset David Arinzon
2024-10-21 5:20 ` [PATCH v1 net-next 3/3] net: ena: Add PHC documentation David Arinzon
2024-10-21 14:32 ` Stanislav Fomichev
2024-10-21 14:45 ` Arinzon, David
2024-10-21 16:24 ` David Woodhouse
2024-10-22 14:17 ` Arinzon, David
2024-10-22 14:25 ` [EXTERNAL] " David Woodhouse
2024-10-22 14:39 ` Arinzon, David
2024-10-21 16:11 ` [PATCH v1 net-next 0/3] PHC support in ENA driver Andrew Lunn
2024-10-22 14:21 ` Arinzon, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd78a56636034961997214e418747d77@amazon.com \
--to=darinzon@amazon.com \
--cc=akiyano@amazon.com \
--cc=aliguori@amazon.com \
--cc=alisaidi@amazon.com \
--cc=amitbern@amazon.com \
--cc=benh@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.co.uk \
--cc=edumazet@google.com \
--cc=evgenys@amazon.com \
--cc=evostrov@amazon.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=maciek@machnikowski.net \
--cc=matua@amazon.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=ndagan@amazon.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=ofirt@amazon.com \
--cc=osamaabb@amazon.com \
--cc=pabeni@redhat.com \
--cc=saeedb@amazon.com \
--cc=shayagr@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).