From: Hayes Wang <hayeswang@realtek.com>
To: lu lu <insyelu@gmail.com>
Cc: "andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
nic_swsd <nic_swsd@realtek.com>, "tiwai@suse.de" <tiwai@suse.de>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] net: usb: r8152: fix transmit queue timeout
Date: Mon, 19 Jan 2026 12:34:15 +0000 [thread overview]
Message-ID: <cd80f6df5c184549a3705efa61d40d58@realtek.com> (raw)
In-Reply-To: <CAAPueM6_GQLcqz+xxKVDOaUZZrDNOnYB_tQ2gaxrUKnDQSZ9cg@mail.gmail.com>
lu lu <insyelu@gmail.com>
> Sent: Monday, January 19, 2026 2:58 PM
[...]
> > Therefore, what needs to be done is to update the timestamp when the TX queue is stopped.
> > Updating trans_start while the TX queue is not stopped is useless.
> if (netif_queue_stopped(tp->netdev)) {
> if (skb_queue_len(&tp->tx_queue) < tp->tx_qlen)
> netif_wake_queue(tp->netdev);
> else
> netif_trans_update(tp->netdev);
> }
> This change continuously updates the trans_start value, even when the
> TX queue has been stopped and its length exceeds the threshold.
> This may prevent the watchdog timer from ever timing out, thereby
> masking potential transmission stall issues.
>
> The timestamp should be updated only upon successful URB submission to
> accurately reflect that the transport layer is still operational.
Although I think a URB error and a transmission stall are different,
I am fine with the simpler approach in v2.
Best Regards,
Hayes
next prev parent reply other threads:[~2026-01-19 12:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 2:56 [PATCH] net: usb: r8152: fix transmit queue timeout insyelu
2026-01-14 4:38 ` Hayes Wang
2026-01-15 1:37 ` lu lu
2026-01-15 11:42 ` Hayes Wang
2026-01-16 2:10 ` lu lu
2026-01-16 3:11 ` Hayes Wang
2026-01-16 7:30 ` lu lu
2026-01-19 2:51 ` Hayes Wang
2026-01-19 6:58 ` lu lu
2026-01-19 12:34 ` Hayes Wang [this message]
2026-01-16 2:37 ` [PATCH v2] " insyelu
2026-01-16 17:32 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd80f6df5c184549a3705efa61d40d58@realtek.com \
--to=hayeswang@realtek.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=insyelu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox