From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD989C04E87 for ; Tue, 21 May 2019 02:30:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B37B92177B for ; Tue, 21 May 2019 02:30:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nmhwmpIq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727711AbfEUCaR (ORCPT ); Mon, 20 May 2019 22:30:17 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:33627 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727078AbfEUCaR (ORCPT ); Mon, 20 May 2019 22:30:17 -0400 Received: by mail-io1-f66.google.com with SMTP id z4so12727862iol.0 for ; Mon, 20 May 2019 19:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7SgdozFln6N4cKOXj579GcIC6rtza9ecdWL5Wy3TukE=; b=nmhwmpIqEdDndur2ChAsWeETvv5l0ZvTBJEtb370hddhGnIxxPPS1QXvF6c0TUXszP Yr7EU9Sh4VKHnget+n7Pms3+v3IYuUFGauOnG3iEQESd5l3m1KSETSuhQO5hYGZ1NfHt LPiqwzXwYjz5n+bQKEtV3fApV8heGjkpZKbic7oS1/rb9uqKH7lXjUbPcj+woOxmTg4Q m0HNFY+GxkdFjyX9PGuOXsaiLoB1kwoZ3BPYPhVnwY5OaAYxdpnZTJTycgmKzxIFJ/Di 1YbAfj1rHtpuQR8vsAEarxyVT+rLh4FomGP4y8JtjYHxGkxYOASMrUtf7pHzRowINwLc 5P4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7SgdozFln6N4cKOXj579GcIC6rtza9ecdWL5Wy3TukE=; b=ZmUFUpaQ8BN/VhlNShhUeIZvwS0HseNE47f3Sdh64EF8oJFicWs1gEY7UO+l7Upikl pREfvewnjA5BWuZhnoXcvbV9MWDmoebltvMBynNrdPeuUEEPJDep3mZE2+S6VYQtXCDd 9J/y8BKvy/p8yTnFpBNch9mFAYO+qj2lg832kWZiKbDUZFpliUarszO63HRDizeNyzhf iN8akCY/hwWY7eP+DgkhostKNwQamRH+DgVKu9OCylLt9WhOpa53yN0Fo9feVCjhpx+e 49YZrEPvRoXt5ssJcjs0bVe87LojndTVA8WI+xoJ6VzixR8T5F8lSZ25xy+8dJ+cUpem WTsg== X-Gm-Message-State: APjAAAWqakj3GHdnn2t6h6YUWOxfUMeG+5DLsZuZ+NuWIWSlf+mtqeLJ bfd5XBPG1gAFcSgmX+l9zV54nQ== X-Google-Smtp-Source: APXvYqz9vj/PZiRmzYCXa+PAsNaZto+wgavDJl397bLT75uosm0y+5EYz+JwQEdkwKsy3yJZG/Ij5A== X-Received: by 2002:a5e:9907:: with SMTP id t7mr4471913ioj.24.1558405816298; Mon, 20 May 2019 19:30:16 -0700 (PDT) Received: from [172.22.22.26] (c-71-195-29-92.hsd1.mn.comcast.net. [71.195.29.92]) by smtp.googlemail.com with ESMTPSA id c3sm5748728iob.80.2019.05.20.19.30.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 May 2019 19:30:15 -0700 (PDT) Subject: Re: [PATCH 1/8] net: qualcomm: rmnet: fix struct rmnet_map_header To: Subash Abhinov Kasiviswanathan Cc: arnd@arndb.de, david.brown@linaro.org, agross@kernel.org, davem@davemloft.net, bjorn.andersson@linaro.org, ilias.apalodimas@linaro.org, cpratapa@codeaurora.org, syadagir@codeaurora.org, evgreen@chromium.org, benchan@google.com, ejcaruso@google.com, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20190520135354.18628-1-elder@linaro.org> <20190520135354.18628-2-elder@linaro.org> <81fd1e01-b8e3-f86a-fcc9-2bcbc51bd679@linaro.org> From: Alex Elder Message-ID: Date: Mon, 20 May 2019 21:30:14 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 5/20/19 8:32 PM, Subash Abhinov Kasiviswanathan wrote: >> >> If you are telling me that the command/data flag resides at bit >> 7 of the first byte, I will update the field masks in a later >> patch in this series to reflect that. >> > > Higher order bit is Command / Data. So what this means is that to get the command/data bit we use: first_byte & 0x80 If that is correct I will remove this patch from the series and will update the subsequent patches so bit 7 is the command bit, bit 6 is reserved, and bits 0-5 are the pad length. I will post a v2 of the series with these changes, and will incorporate Bjorn's "Reviewed-by". -Alex