From: David Ahern <dsahern@gmail.com>
To: Peter Oskolkov <posk@posk.io>
Cc: Peter Oskolkov <posk@google.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next] selftests: bpf: add VRF test cases to lwt_ip_encap test.
Date: Wed, 10 Apr 2019 22:04:34 -0700 [thread overview]
Message-ID: <cd8f31de-aaae-db13-4755-400f5d335b2f@gmail.com> (raw)
In-Reply-To: <CAFTs51XM3XUTCSGbhP=Xr+8__ezvMNVabMmGPbHk393rXazABw@mail.gmail.com>
On 4/10/19 9:38 PM, Peter Oskolkov wrote:
>>
>> Notice the "No route to host" errors.
>
> "No route to host" is OK: there are negative tests, as you requested a
> couple of months ago... :), and these tests correctly trigger "no
> route to host".
>
> This output basically tell me that the test passes, both with and without VRF.
ok, expected errors like that should be trapped and hidden. I can barely
remember what I had for breakfast yesterday, let alone that errors like
this are ok months after the initial test submission.
Again, I reference what I did for fib_tests as an example of how I think
tests should be written: 1 line per test with OK/FAIL at the end of the
line, expected errors trapped so a clean runs shows only clean output,
verbose option and pause-on-fail option to help diagnose errors when a
test breaks.
...
>> ###
>>
>> so netcat is not the right package. 'apt-cache search netcat' shows
>> another package, so try it.
>
> I guess Debian Stretch has a too old version of netcat that does not
> support the flags used in the test.
I don't have recent Fedora VMs setup to run these tests, but within
reason they should work across OS versions (reason to me being widely
used OS'es like Debian, Fedora and Ubuntu).
next prev parent reply other threads:[~2019-04-11 5:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 15:43 [PATCH bpf-next] selftests: bpf: add VRF test cases to lwt_ip_encap test Peter Oskolkov
2019-04-04 5:09 ` Martin Lau
2019-04-04 15:04 ` David Ahern
2019-04-04 15:05 ` David Ahern
2019-04-05 2:32 ` David Ahern
2019-04-09 9:48 ` Daniel Borkmann
2019-04-09 16:57 ` David Ahern
2019-04-11 1:19 ` David Ahern
2019-04-11 1:26 ` Peter Oskolkov
2019-04-11 4:17 ` David Ahern
2019-04-11 4:38 ` Peter Oskolkov
2019-04-11 5:04 ` David Ahern [this message]
2019-04-17 2:23 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd8f31de-aaae-db13-4755-400f5d335b2f@gmail.com \
--to=dsahern@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=posk@google.com \
--cc=posk@posk.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).