* [PATCH] Add MIPS dependency for dm9000 driver
@ 2005-11-30 17:18 Franck
2005-11-30 21:27 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Franck @ 2005-11-30 17:18 UTC (permalink / raw)
To: lkml, netdev
The attached patch adds MIPS dependency for dm9000 ethernet
controller. Indeed this controller is used by some embedded platforms
based on MIPS CPUs.
Signed-Off-By: Franck Bui-Huu <franck.bui@gmail.com>
---
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index f15f909..1b00169 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -856,7 +856,7 @@ config SMC9194
config DM9000
tristate "DM9000 support"
- depends on ARM && NET_ETHERNET
+ depends on (ARM || MIPS) && NET_ETHERNET
select CRC32
select MII
---help---
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Add MIPS dependency for dm9000 driver
2005-11-30 17:18 [PATCH] Add MIPS dependency for dm9000 driver Franck
@ 2005-11-30 21:27 ` Andrew Morton
2005-12-01 8:05 ` Franck
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2005-11-30 21:27 UTC (permalink / raw)
To: Franck; +Cc: linux-kernel, netdev
Franck <vagabon.xyz@gmail.com> wrote:
>
> The attached patch adds MIPS dependency for dm9000 ethernet
> controller. Indeed this controller is used by some embedded platforms
> based on MIPS CPUs.
>
> Signed-Off-By: Franck Bui-Huu <franck.bui@gmail.com>
> ---
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index f15f909..1b00169 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -856,7 +856,7 @@ config SMC9194
>
> config DM9000
> tristate "DM9000 support"
> - depends on ARM && NET_ETHERNET
> + depends on (ARM || MIPS) && NET_ETHERNET
> select CRC32
> select MII
Is there any reason why we cannot enable this driver on all architectures?
It's moderately important for quality and maintainability reasons that it
be included in the x86 build, at least..
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Add MIPS dependency for dm9000 driver
2005-11-30 21:27 ` Andrew Morton
@ 2005-12-01 8:05 ` Franck
0 siblings, 0 replies; 3+ messages in thread
From: Franck @ 2005-12-01 8:05 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, netdev
Hi Andrew
2005/11/30, Andrew Morton <akpm@osdl.org>:
> Franck <vagabon.xyz@gmail.com> wrote:
> >
> > The attached patch adds MIPS dependency for dm9000 ethernet
> > controller. Indeed this controller is used by some embedded platforms
> > based on MIPS CPUs.
> >
>
> Is there any reason why we cannot enable this driver on all architectures?
>
> It's moderately important for quality and maintainability reasons that it
> be included in the x86 build, at least..
>
Actually there's a discussion about that. I previously sent a RFC
(subject is "[NET] Remove ARM dependency for dm9000 driver") for that.
Now some people are reacting so we should wait for the last words
before applying something.
thanks
--
Franck
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-12-01 8:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-30 17:18 [PATCH] Add MIPS dependency for dm9000 driver Franck
2005-11-30 21:27 ` Andrew Morton
2005-12-01 8:05 ` Franck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).