From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jean-Louis Dupond <jean-louis@dupond.be>,
netdev@vger.kernel.org, edumazet@google.com
Subject: Re: SACK compression patch causing performance drop
Date: Thu, 8 Nov 2018 07:14:46 -0800 [thread overview]
Message-ID: <cdbdedbf-bd48-5e3f-465a-81929e7db27f@gmail.com> (raw)
In-Reply-To: <ce731718-3f9d-04df-d6d2-a300d3b4fc29@dupond.be>
On 11/08/2018 12:23 AM, Jean-Louis Dupond wrote:
> Hi,
>
> Was somebody able to check this?
> Really think this should be fixed :)
>
> Thanks
> Jean-Louis
>
I somehow missed this email.
Packet captures might help, please send me
tcpdump -s 128 -i ethX -w sack.pcap
of some samples with or without the sack compression enabled.
> On 3/11/18 16:59, Jean-Louis Dupond wrote:
>> Hi All,
>>
>> On recent kernels we noticed a way lower throughput to our SAN system than before.
>> While on pre 4.18 kernels we had 400-700MB/sec read speed, on 4.18+ we only had 70-120MB/sec.
>>
>> The SAN is connected via iSCSI over a 10G network (ixgbe/X520 NICS if it matters).
>>
>> After some debugging, I tried to bisect between 4.17 and 4.18 to see what commit caused the slowdown.
>> It showed that the addition of the SACK compression (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5d9f4262b7ea41ca9981cc790e37cca6e37c789e) was the cause.
>>
>> And indeed, if I set net.ipv4.tcp_comp_sack_nr to 0 on 4.19 for example, the throughput is (almost) back to normal again.
>> So it seems like this change causes quite some performance issues.
>>
>> Any ideas?
>>
>> Thanks
>> Jean-Louis
>>
next prev parent reply other threads:[~2018-11-09 0:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-03 15:59 SACK compression patch causing performance drop Jean-Louis Dupond
2018-11-08 8:23 ` Jean-Louis Dupond
2018-11-08 15:14 ` Eric Dumazet [this message]
2018-11-10 22:07 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdbdedbf-bd48-5e3f-465a-81929e7db27f@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=edumazet@google.com \
--cc=jean-louis@dupond.be \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).