Re: [PATCH net-next v35 0/8] eea: Add basic driver framework for Alibaba Elastic Ethernet Adaptor

[Paolo Abeni <pabeni@redhat.com>]

On 3/26/26 12:38 PM, Xuan Zhuo wrote:
> On Thu, 26 Mar 2026 12:26:33 +0100, Paolo Abeni <pabeni@redhat.com> wrote:
>> On 3/23/26 8:44 AM, Xuan Zhuo wrote:
>>> Add a driver framework for EEA that will be available in the future.
>>>
>>> This driver is currently quite minimal, implementing only fundamental
>>> core functionalities. Key features include: I/O queue management via
>>> adminq, basic PCI-layer operations, and essential RX/TX data
>>> communication capabilities. It also supports the creation,
>>> initialization, and management of network devices (netdev). Furthermore,
>>> the ring structures for both I/O queues and adminq have been abstracted
>>> into a simple, unified, and reusable library implementation,
>>> facilitating future extension and maintenance.
>>
>> Unfortunately sashiko fund more stuff:
>>
>> https://sashiko.dev/#/patchset/20260323074441.91691-1-xuanzhuo%40linux.alibaba.com
>>
>> AFAIK checks vs malicious values from the H/W are not due, but stats
>> endianness, 32-bits, truesize related concerns looks real.
> 
> I've looked at this, and I think most of it is meaningless. For example, since
> we have the following options,
> 
> +	depends on 64BIT
> 
> there's no need to consider some 32-bit related issues. Many other points are
> also unnecessary.
> 
> I will go through these comments again. I'll try to fix them.
> I might introduce some defensive programming. ^_^ Just to make the
> AI happy. However, I can't make all these comments disappear.
Please, don't add defensive programming for AI's sake. AI reviews are
threaded alike other reviews: if there are valid argument to counter
them, should be ignored. Please instead mention on the ML why specific
comments are not relevant.

Note that defensive checks vs rouge H/W are AFAIK not needed, no need to
argument that.

/P