From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDC7AC433F5 for ; Sun, 24 Apr 2022 16:10:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233809AbiDXQNu (ORCPT ); Sun, 24 Apr 2022 12:13:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231447AbiDXQNu (ORCPT ); Sun, 24 Apr 2022 12:13:50 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4895B54F99 for ; Sun, 24 Apr 2022 09:10:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 07BFAB80AB3 for ; Sun, 24 Apr 2022 16:10:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F895C385A7; Sun, 24 Apr 2022 16:10:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650816646; bh=G9fUkkjUSdBw+xD7bLt329nQj6C966TD800VXHVJMpA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UFEJSnN99OmMOal/RX742b4gHOqSKgcRJ30W7hmaj5eKnwQSmixcQ1+EQGLsMQ9bu yvGR24fmGn0kol+rRNbJbm5GrqDg7QTG1xmwpDtkRbBFgjeQAko8x+lQw01XJMy0S7 OybpcHUKqAjkGlcOaAqp/WPB15LmFyuErbnbDa/oQNonLTr4sAsxSe1mJI49fBeXCe JnQqkEJHk9RLIK79cUqCfVp8VhnBrbXnthB16GUrBBP1ENgLHYIdS6PUAfWiJ90uJE 2QRUquGlu4fYZNNMUsMn6z5QbJOodl25GUNncm0HrJcD+N/FdpSR41UTGjpfrXfnDl 5wYOo1jkY2SYw== Message-ID: Date: Sun, 24 Apr 2022 10:10:44 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH iproute2-next 1/3] libbpf: Use bpf_object__load instead of bpf_object__load_xattr Content-Language: en-US To: Hangbin Liu Cc: netdev@vger.kernel.org, stephen@networkplumber.org, toke@redhat.com, Paul Chaignon References: <20220423152300.16201-1-dsahern@kernel.org> <20220423152300.16201-2-dsahern@kernel.org> From: David Ahern In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/23/22 7:56 PM, Hangbin Liu wrote: > Hi David, > > This patch revert c04e45d0 lib/bpf: fix verbose flag when using libbpf, > Should we set prog->log_level directly before it loaded, like > bpf_program__set_log_level() does? > that API is new - Dec 2021 so it will not be present across relevant libbpf versions. Detecting what exists in a libbpf version and adding compat wrappers needs to be added. That's an undertaking I do not have time for at the moment. If you or someone else does it would be appreciated.