From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com ([209.85.128.196]:36048 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751786AbeB0TgV (ORCPT ); Tue, 27 Feb 2018 14:36:21 -0500 Received: by mail-wr0-f196.google.com with SMTP id v111so13857516wrb.3 for ; Tue, 27 Feb 2018 11:36:21 -0800 (PST) Subject: Re: [PATCH net-next 01/11] ipmr,ipmr6: Define a uniform vif_device To: Yuval Mintz , netdev@vger.kernel.org Cc: mlxsw@mellanox.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org References: <1519757908-32863-1-git-send-email-yuvalm@mellanox.com> <1519757908-32863-2-git-send-email-yuvalm@mellanox.com> From: Nikolay Aleksandrov Message-ID: Date: Tue, 27 Feb 2018 21:36:18 +0200 MIME-Version: 1.0 In-Reply-To: <1519757908-32863-2-git-send-email-yuvalm@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 27/02/18 20:58, Yuval Mintz wrote: > The two implementations have almost identical structures - vif_device and > mif_device. As a step toward uniforming the mr_tables, eliminate the > mif_device and relocate the vif_device definition into a new common > header file. > > Also, introduce a common initializing function for setting most of the > vif_device fields in a new common source file. This requires modifying > the ipv{4,6] Kconfig and ipv4 makefile as we're introducing a new common > config option - CONFIG_IP_MROUTE_COMMON. > > Signed-off-by: Yuval Mintz > --- > include/linux/mroute.h | 13 +----------- > include/linux/mroute6.h | 11 +--------- > include/linux/mroute_base.h | 52 +++++++++++++++++++++++++++++++++++++++++++++ > net/ipv4/Kconfig | 5 +++++ > net/ipv4/Makefile | 1 + > net/ipv4/ipmr.c | 32 +++++++++++++--------------- > net/ipv4/ipmr_base.c | 28 ++++++++++++++++++++++++ > net/ipv6/Kconfig | 1 + > net/ipv6/ip6mr.c | 37 ++++++++++++-------------------- > 9 files changed, 117 insertions(+), 63 deletions(-) > create mode 100644 include/linux/mroute_base.h > create mode 100644 net/ipv4/ipmr_base.c > Acked-by: Nikolay Aleksandrov