netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kirill Tkhai <ktkhai@virtuozzo.com>
To: Jon Maloy <jon.maloy@ericsson.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	syzbot <syzbot+749d9d87c294c00ca856@syzkaller.appspotmail.com>,
	Ying Xue <ying.xue@windriver.com>
Cc: Andrei Vagin <avagin@virtuozzo.com>,
	David Miller <davem@davemloft.net>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Florian Westphal <fw@strlen.de>,
	LKML <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>,
	Nicolas Dichtel <nicolas.dichtel@6wind.com>,
	"roman.kapl@sysgo.com" <roman.kapl@sysgo.com>,
	"syzkaller-bugs@googlegroups.com"
	<syzkaller-bugs@googlegroups.com>,
	"tipc-discussion@lists.sourceforge.net"
	<tipc-discussion@lists.sourceforge.net>
Subject: Re: BUG: sleeping function called from invalid context at net/core/sock.c:LINE (3)
Date: Mon, 19 Feb 2018 17:41:54 +0300	[thread overview]
Message-ID: <cdfcb6f4-f2db-b710-1b6d-cf15b022c2d3@virtuozzo.com> (raw)
In-Reply-To: <BN6PR15MB155309E2A35F66298DAD8E2E9AC80@BN6PR15MB1553.namprd15.prod.outlook.com>

On 19.02.2018 16:23, Jon Maloy wrote:
> I don't understand this one. tipc_topsrv_stop() can only be trigged from a user doing rmmod(), and I double checked that this is running in user mode.
> How does the call chain you are reporting occur?
> 

In case of CONFIG_NET_NS=y, pernet_operations::exit() is called after last reference
to a net is dropped. So, this may happen not only on module unload path.

Kirill

> 
> 
>> -----Original Message-----
>> From: Kirill Tkhai [mailto:ktkhai@virtuozzo.com]
>> Sent: Saturday, February 17, 2018 23:23
>> To: Dmitry Vyukov <dvyukov@google.com>; syzbot
>> <syzbot+749d9d87c294c00ca856@syzkaller.appspotmail.com>; Jon Maloy
>> <jon.maloy@ericsson.com>; Ying Xue <ying.xue@windriver.com>
>> Cc: Andrei Vagin <avagin@virtuozzo.com>; David Miller
>> <davem@davemloft.net>; Eric W. Biederman <ebiederm@xmission.com>;
>> Florian Westphal <fw@strlen.de>; LKML <linux-kernel@vger.kernel.org>;
>> netdev <netdev@vger.kernel.org>; Nicolas Dichtel
>> <nicolas.dichtel@6wind.com>; roman.kapl@sysgo.com; syzkaller-
>> bugs@googlegroups.com; tipc-discussion@lists.sourceforge.net
>> Subject: Re: BUG: sleeping function called from invalid context at
>> net/core/sock.c:LINE (3)
>>
>> On 17.02.2018 11:15, Dmitry Vyukov wrote:
>>> On Sat, Feb 17, 2018 at 4:00 AM, syzbot
>>> <syzbot+749d9d87c294c00ca856@syzkaller.appspotmail.com> wrote:
>>>> Hello,
>>>>
>>>> syzbot hit the following crash on net-next commit
>>>> 65bd449c32c2745df61913ab54087e77f9d9b70d (Fri Feb 16 20:26:35 2018
>>>> +0000) Merge branch 'tipc-de-generealize-topology-server'
>>>
>>> +tipc maintainers
>>
>> This looks to be caused by commit 0ef897be12b8
>> "tipc: separate topology server listener socket from subcsriber sockets"
>>
>> Thanks,
>> Kirill

      parent reply	other threads:[~2018-02-19 14:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-17  3:00 BUG: sleeping function called from invalid context at net/core/sock.c:LINE (3) syzbot
2018-02-17  8:15 ` Dmitry Vyukov
2018-02-17 22:23   ` Kirill Tkhai
2018-02-19 13:23     ` Jon Maloy
2018-02-19 13:32       ` Dmitry Vyukov
2018-02-19 13:57       ` Paolo Abeni
2018-02-19 14:14         ` syzbot
2018-02-19 14:41       ` Kirill Tkhai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cdfcb6f4-f2db-b710-1b6d-cf15b022c2d3@virtuozzo.com \
    --to=ktkhai@virtuozzo.com \
    --cc=avagin@virtuozzo.com \
    --cc=davem@davemloft.net \
    --cc=dvyukov@google.com \
    --cc=ebiederm@xmission.com \
    --cc=fw@strlen.de \
    --cc=jon.maloy@ericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=roman.kapl@sysgo.com \
    --cc=syzbot+749d9d87c294c00ca856@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=tipc-discussion@lists.sourceforge.net \
    --cc=ying.xue@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).