From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 797043B1034; Fri, 5 Jun 2026 02:42:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780627376; cv=none; b=kfVLlO68BU7mXV3GdrcgMB13jdzB3HXiOh1F2FdnNJztF4/yma+qjBMpcDUsdshbhouU7NLg+OCO3Z09rSKfLdlqSLOujiH3HP7Sym32YmBpkWs7gdpch7P+jpcqe33ULJRLgmChscAIw3KOcfy/OBkgef+FMjQ/kTwsg2Mp0tI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780627376; c=relaxed/simple; bh=knbVBzJHTBJPWyNraPAnWOt877mFScuJwtybl6ywCGs=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=b8POEw7x7cWOECIFyfwyilBzBliOgvJ/h4HUt1nd7dfNncM1dVjFJKVGYXsYo155SIa2YQt0E+2UbFaDy58/s1dLaZI47gHgBHkR6Q96310mgYoqPFTZn1PWky/76dQELkewpn2giQ5EJYd13jQuaFM97qufUR95hzGAfbmMFXQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realtek.com; spf=pass smtp.mailfrom=realtek.com; dkim=pass (2048-bit key) header.d=realtek.com header.i=@realtek.com header.b=QFgwXWsG; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realtek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realtek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=realtek.com header.i=@realtek.com header.b="QFgwXWsG" X-SpamFilter-By: ArmorX SpamTrap 5.80 with qID 6552gZtgD1062172, This message is accepted by code: ctloc85258 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=realtek.com; s=dkim; t=1780627355; bh=MRgeh7Vod5VyrL8PqUQs6OOiUqbq/RWGPVA2a0PITHQ=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:Content-Transfer-Encoding:MIME-Version; b=QFgwXWsGnsRGyvhcKw44FxU0C9r77WSMy0nAzAIW1x/IvZaq8E4QZPPrbwV0BPsRj BnsmAQ0V5XjH5OaSXZeovWYVywaVklpS5MutlTaCr+3KpsthR3+NY5j/R3U0JrqGL+ ik1HCJ0h1fasGCL5NobkE7e09rdxoL5wnEQg5KTcHSt9c//SoDlAQV2yVV2mSMFnUY kkwtZQP2fuVCLXhh+R6EZQQEe/ZyaorrsUibAfuzxNhwIbVeeGmOHiY6s6rvRAdI+h YbKAy2+WHp9jTMbTW5KBEu0Lops7gUM2WwlAjif23e1uU31cyDf7LpiRx+1wkdOQdM q++xnVZ+JZp6A== Received: from mail.realtek.com (rtkexhmbs04.realtek.com.tw[10.21.1.54]) by rtits2.realtek.com.tw (8.15.2/3.28/5.94) with ESMTPS id 6552gZtgD1062172 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 5 Jun 2026 10:42:35 +0800 Received: from RTKEXHMBS05.realtek.com.tw (10.21.1.55) by RTKEXHMBS04.realtek.com.tw (10.21.1.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Jun 2026 10:42:35 +0800 Received: from RTKEXHMBS06.realtek.com.tw (10.21.1.56) by RTKEXHMBS05.realtek.com.tw (10.21.1.55) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Jun 2026 10:42:34 +0800 Received: from RTKEXHMBS06.realtek.com.tw ([::1]) by RTKEXHMBS06.realtek.com.tw ([fe80::e6fd:5a3f:8946:92c4%10]) with mapi id 15.02.2562.017; Fri, 5 Jun 2026 10:42:34 +0800 From: Chih Kai Hsu To: Andrew Lunn CC: "kuba@kernel.org" , "davem@davemloft.net" , "netdev@vger.kernel.org" , nic_swsd , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" Subject: RE: [PATCH net] r8152: handle the return value of usb_reset_device() Thread-Topic: [PATCH net] r8152: handle the return value of usb_reset_device() Thread-Index: AQHc9APC9XApZAQtH0mFd55w2OdfKbYt1DKAgAFpdUA= Date: Fri, 5 Jun 2026 02:42:34 +0000 Message-ID: References: <20260604092247.27158-450-nic_swsd@realtek.com> In-Reply-To: Accept-Language: zh-TW, en-US Content-Language: zh-TW Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On 04/06/26 8:54 pm, Andrew Lunn wrote: > On Thu, Jun 04, 2026 at 05:22:47PM +0800, Chih Kai Hsu wrote: > > If usb_reset_device() returns a negative error code, stop the process > > of probing. > > > > Fixes: 10c3271712f5 ("r8152: disable the ECM mode") >=20 > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html >=20 > Does this bother people? Yes, it does. If the driver does not return early when receiving an error code from usb_r= eset_device(), the subsequent execution will trigger a kernel call trace. >=20 > Andrew Best Regards, Chih Kai