* [PATCH] ATM-lanai: Delete an error message for a failed memory allocation in lanai_init_one()
@ 2017-08-06 8:00 SF Markus Elfring
0 siblings, 0 replies; only message in thread
From: SF Markus Elfring @ 2017-08-06 8:00 UTC (permalink / raw)
To: linux-atm-general, netdev, Chas Williams; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 6 Aug 2017 09:42:52 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/atm/lanai.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/atm/lanai.c b/drivers/atm/lanai.c
index 2351dad78ff5..f4cb6c5870bf 100644
--- a/drivers/atm/lanai.c
+++ b/drivers/atm/lanai.c
@@ -2562,11 +2562,8 @@ static int lanai_init_one(struct pci_dev *pci,
int result;
lanai = kmalloc(sizeof(*lanai), GFP_KERNEL);
- if (lanai == NULL) {
- printk(KERN_ERR DEV_LABEL
- ": couldn't allocate dev_data structure!\n");
+ if (!lanai)
return -ENOMEM;
- }
atmdev = atm_dev_register(DEV_LABEL, &pci->dev, &ops, -1, NULL);
if (atmdev == NULL) {
--
2.13.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-08-06 8:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-06 8:00 [PATCH] ATM-lanai: Delete an error message for a failed memory allocation in lanai_init_one() SF Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).