From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF504C433DB for ; Fri, 12 Feb 2021 18:06:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6B9C64DA5 for ; Fri, 12 Feb 2021 18:06:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231396AbhBLSGD (ORCPT ); Fri, 12 Feb 2021 13:06:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230240AbhBLSF7 (ORCPT ); Fri, 12 Feb 2021 13:05:59 -0500 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2DC2C061574; Fri, 12 Feb 2021 10:05:20 -0800 (PST) Received: by mail-pl1-x635.google.com with SMTP id a24so245379plm.11; Fri, 12 Feb 2021 10:05:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=e7FvX3805mVbi8rUejyIm26agQLfcgUZJrMWSiLjNGs=; b=lNMCouqv+fTjmMB6cirFrl9lgwfiYme91mERyye0MrSQwDCWRBAA8nxOyadU0JP1GM 2+78codzGdNu57tEuXnoFu7IobxUP2aYirkbJr28Dm7BWbmrvwUwjBcmrPiAYh+qBgtO 2oi4c6DHF22Kn9p7hWKmzSLq3BrbDfp1snMMHl4gbxbz70OOyBegaRybHK+9kTsuJelI sX9n3adDZpn2lvnhNC9ZnBin4UlcBYC1LTzYqPV9XqtyKQVe7EUeGDgd/KTQlJ0iZiLp fwm/Zs1QqxP+LnnLT9T4qzF2MEyxwZGEGwECPkLtovPlelRmrQOiI2Cl779Kna3slRjJ PNBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=e7FvX3805mVbi8rUejyIm26agQLfcgUZJrMWSiLjNGs=; b=h88VgQjiww7lonaGjvTneYaRQ1whgucgiy2sUobkOJBatsodP57ggqhLTvIriZbaMI FgiOjOWh7ZEZ1Rnjg+weFBseQGvocmrXoX5892Pm9eTbYHXTXptG9sg+UAPO/T+oG0op n/3MvrZUYscvRndUTnhjWV0BphhsLCJyPmfvhter5zOqDnxl99GmKNyI9o4CNq7Rtxsf 7ll8HmlgibQjS92QYewBgpgWIumAC1PPL9xunmn34XcESagtZjkc6zvR2lt+9EQ1TurB MNihg0UUkviyNKWwJnyxcOLMVyawQsbrxmc9X+ElRiAKUpciauJYepqez1TJ10nvlHV9 oxkg== X-Gm-Message-State: AOAM533HHK29Pu3wFAjGm8RVgtC3l1IXl7E+BgEISnEdN6hQE7d2rMXF jzOr9Oe7o5GxDFfmywu7ibCdZmy5bGs= X-Google-Smtp-Source: ABdhPJxbX9H47ViGLWUpCf4ZDXGVxxJ2XlKtdlv42d9ua1WR5Bsy0WUcnV+kUq8ziygwgtpEbfgKww== X-Received: by 2002:a17:90a:ad09:: with SMTP id r9mr3793493pjq.51.1613153119543; Fri, 12 Feb 2021 10:05:19 -0800 (PST) Received: from [10.230.29.30] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id r13sm10104082pfc.198.2021.02.12.10.05.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Feb 2021 10:05:19 -0800 (PST) Subject: Re: [PATCH v5 net-next 02/10] net: bridge: offload all port flags at once in br_setport To: Vladimir Oltean , Jakub Kicinski , "David S. Miller" Cc: Andrew Lunn , Vivien Didelot , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org, Roopa Prabhu , Nikolay Aleksandrov , Jiri Pirko , Ido Schimmel , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Vadym Kochan , Taras Chornyi , Grygorii Strashko , Vignesh Raghavendra , Ioana Ciornei , Ivan Vecera , linux-omap@vger.kernel.org References: <20210212151600.3357121-1-olteanv@gmail.com> <20210212151600.3357121-3-olteanv@gmail.com> From: Florian Fainelli Message-ID: Date: Fri, 12 Feb 2021 10:05:15 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210212151600.3357121-3-olteanv@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/12/2021 7:15 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > If for example this command: > > ip link set swp0 type bridge_slave flood off mcast_flood off learning off > > succeeded at configuring BR_FLOOD and BR_MCAST_FLOOD but not at > BR_LEARNING, there would be no attempt to revert the partial state in > any way. Arguably, if the user changes more than one flag through the > same netlink command, this one _should_ be all or nothing, which means > it should be passed through switchdev as all or nothing. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian