From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jean-Louis Dupond <jean-louis@dupond.be>
Subject: Re: SACK compression patch causing performance drop
Date: Thu, 8 Nov 2018 09:23:19 +0100
Message-ID: <ce731718-3f9d-04df-d6d2-a300d3b4fc29@dupond.be>
References: <89214271-4496-c438-c4e8-b39f0ae72af7@dupond.be>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: netdev@vger.kernel.org, edumazet@google.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from apollo.dupie.be ([62.210.113.39]:39078 "EHLO apollo.dupie.be"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726133AbeKHSF4 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 8 Nov 2018 13:05:56 -0500
In-Reply-To: <89214271-4496-c438-c4e8-b39f0ae72af7@dupond.be>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hi,

Was somebody able to check this?
Really think this should be fixed :)

Thanks
Jean-Louis

On 3/11/18 16:59, Jean-Louis Dupond wrote:
> Hi All,
>
> On recent kernels we noticed a way lower throughput to our SAN system 
> than before.
> While on pre 4.18 kernels we had 400-700MB/sec read speed, on 4.18+ we 
> only had 70-120MB/sec.
>
> The SAN is connected via iSCSI over a 10G network (ixgbe/X520 NICS if 
> it matters).
>
> After some debugging, I tried to bisect between 4.17 and 4.18 to see 
> what commit caused the slowdown.
> It showed that the addition of the SACK compression 
> (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5d9f4262b7ea41ca9981cc790e37cca6e37c789e) 
> was the cause.
>
> And indeed, if I set net.ipv4.tcp_comp_sack_nr to 0 on 4.19 for 
> example, the throughput is (almost) back to normal again.
> So it seems like this change causes quite some performance issues.
>
> Any ideas?
>
> Thanks
> Jean-Louis
>