From: David Ahern <dsahern@kernel.org>
To: Kuniyuki Iwashima <kuniyu@amazon.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next 6/7] nexthop: Convert RTM_NEWNEXTHOP to per-netns RTNL.
Date: Thu, 20 Mar 2025 08:20:33 -0600 [thread overview]
Message-ID: <ce7ce83f-b52f-443e-97f8-beffde023274@kernel.org> (raw)
In-Reply-To: <20250319230743.65267-7-kuniyu@amazon.com>
On 3/19/25 5:06 PM, Kuniyuki Iwashima wrote:
> If we pass false to the rtnl_held param of lwtunnel_valid_encap_type(),
> we can move RTNL down before rtm_to_nh_config_rtnl().
>
> Let's use rtnl_net_lock() in rtm_new_nexthop().
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
> ---
> net/ipv4/nexthop.c | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2025-03-20 14:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 23:06 [PATCH v2 net-next 0/7] nexthop: Convert RTM_{NEW,DEL}NEXTHOP to per-netns RTNL Kuniyuki Iwashima
2025-03-19 23:06 ` [PATCH v2 net-next 1/7] nexthop: Move nlmsg_parse() in rtm_to_nh_config() to rtm_new_nexthop() Kuniyuki Iwashima
2025-03-20 3:13 ` David Ahern
2025-03-20 7:00 ` Eric Dumazet
2025-03-19 23:06 ` [PATCH v2 net-next 2/7] nexthop: Split nh_check_attr_group() Kuniyuki Iwashima
2025-03-20 7:05 ` Eric Dumazet
2025-03-20 14:20 ` David Ahern
2025-03-19 23:06 ` [PATCH v2 net-next 3/7] nexthop: Move NHA_OIF validation to rtm_to_nh_config_rtnl() Kuniyuki Iwashima
2025-03-20 7:06 ` Eric Dumazet
2025-03-20 14:20 ` David Ahern
2025-03-19 23:06 ` [PATCH v2 net-next 4/7] nexthop: Check NLM_F_REPLACE and NHA_ID in rtm_new_nexthop() Kuniyuki Iwashima
2025-03-20 7:07 ` Eric Dumazet
2025-03-20 14:20 ` David Ahern
2025-03-19 23:06 ` [PATCH v2 net-next 5/7] nexthop: Remove redundant group len check in nexthop_create_group() Kuniyuki Iwashima
2025-03-20 7:07 ` Eric Dumazet
2025-03-20 14:20 ` David Ahern
2025-03-19 23:06 ` [PATCH v2 net-next 6/7] nexthop: Convert RTM_NEWNEXTHOP to per-netns RTNL Kuniyuki Iwashima
2025-03-20 7:12 ` Eric Dumazet
2025-03-20 14:20 ` David Ahern [this message]
2025-03-19 23:06 ` [PATCH v2 net-next 7/7] nexthop: Convert RTM_DELNEXTHOP " Kuniyuki Iwashima
2025-03-20 7:12 ` Eric Dumazet
2025-03-20 14:20 ` David Ahern
2025-03-24 9:35 ` [PATCH v2 net-next 0/7] nexthop: Convert RTM_{NEW,DEL}NEXTHOP " Ido Schimmel
2025-03-24 19:03 ` Kuniyuki Iwashima
2025-03-25 15:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce7ce83f-b52f-443e-97f8-beffde023274@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).