From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next 02/12] net: phy: et1011c: Remove incorrect missing 1000 Half Date: Mon, 3 Sep 2018 10:46:35 -0700 Message-ID: References: <1535908001-18593-1-git-send-email-andrew@lunn.ch> <1535908001-18593-3-git-send-email-andrew@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev , maxime.chevallier@bootlin.com To: Andrew Lunn , David Miller Return-path: Received: from mail-pf1-f196.google.com ([209.85.210.196]:40036 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727414AbeICWIA (ORCPT ); Mon, 3 Sep 2018 18:08:00 -0400 Received: by mail-pf1-f196.google.com with SMTP id s13-v6so463490pfi.7 for ; Mon, 03 Sep 2018 10:46:47 -0700 (PDT) In-Reply-To: <1535908001-18593-3-git-send-email-andrew@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 9/2/2018 10:06 AM, Andrew Lunn wrote: > The driver indicates it can do 10/100 full and half duplex, plus 1G > Full. The datasheet indicates 1G half is also supported. So make use > of the standard PHY_GBIT_FEATURES. > > It could be, this was added because there is a MAC which does not > support 1G half. Bit this is the wrong place to enforce this. Indeed, this should not be left to the PHY to decide, although in my experience using 1000/Half is always a "roll the dice" thing, since it is not AFAIR properly specified. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian