From: Florian Fainelli <f.fainelli@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org
Cc: davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com,
jakub.kicinski@netronome.com, dirk.vandermerwe@netronome.com,
andrew@lunn.ch, vivien.didelot@gmail.com
Subject: Re: [patch net-next RFC 5/8] mlxsw: Remove ndo_get_port_parent_id implementation
Date: Fri, 1 Mar 2019 18:57:07 -0800 [thread overview]
Message-ID: <cec74211-9663-8aa1-8eb4-0f218277bd2f@gmail.com> (raw)
In-Reply-To: <20190301160542.6474-6-jiri@resnulli.us>
On 3/1/2019 8:05 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@mellanox.com>
>
> Remove implementation of get_port_parent_id ndo and rely on core calling
> into devlink for the information directly.
>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Don't you need a select/depends on DEVLINK for MLXSW_SWITCHX2 and
MLXSW_SPECTRUM otherwise you are going to get unexpected results from
net/bridge/br_switchdev.c while computing the offload_fwd_mark?
--
Florian
next prev parent reply other threads:[~2019-03-02 2:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 16:05 [patch net-next RFC 0/8] net: expose switch ID via devlink Jiri Pirko
2019-03-01 16:05 ` [patch net-next RFC 1/8] net: devlink: convert devlink_port_attrs bools to bits Jiri Pirko
2019-03-02 2:48 ` Florian Fainelli
2019-03-01 16:05 ` [patch net-next RFC 2/8] net: devlink: extend port attrs for switch ID Jiri Pirko
2019-03-02 2:53 ` Florian Fainelli
2019-03-02 7:34 ` Jiri Pirko
2019-03-01 16:05 ` [patch net-next RFC 3/8] net: devlink: introduce devlink_compat_switch_id_get() helper Jiri Pirko
2019-03-01 16:45 ` Jakub Kicinski
2019-03-01 16:40 ` Jiri Pirko
2019-03-01 16:05 ` [patch net-next RFC 4/8] mlxsw: Pass switch ID through devlink_port_attrs_set() Jiri Pirko
2019-03-01 16:05 ` [patch net-next RFC 5/8] mlxsw: Remove ndo_get_port_parent_id implementation Jiri Pirko
2019-03-02 2:57 ` Florian Fainelli [this message]
2019-03-02 7:36 ` Jiri Pirko
2019-03-01 16:05 ` [patch net-next RFC 6/8] nfp: pass switch ID through devlink_port_attrs_set() Jiri Pirko
2019-03-01 16:05 ` [patch net-next RFC 7/8] nfp: register devlink port before netdev Jiri Pirko
2019-03-01 16:05 ` [patch net-next RFC 8/8] nfp: remove ndo_get_port_parent_id implementation Jiri Pirko
2019-03-02 2:58 ` Florian Fainelli
2019-03-02 2:58 ` [patch net-next RFC 0/8] net: expose switch ID via devlink Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cec74211-9663-8aa1-8eb4-0f218277bd2f@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dirk.vandermerwe@netronome.com \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).