From: "Arınç ÜNAL" <arinc.unal@arinc9.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Felix Fietkau" <nbd@nbd.name>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>
Cc: Network Development <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-mips@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-mediatek <linux-mediatek@lists.infradead.org>,
Sergio Paracuellos <sergio.paracuellos@gmail.com>,
Daniel Golle <daniel@makrotopia.org>
Subject: Re: MediaTek Frame Engine Ethernet: does it need any resets?
Date: Sat, 29 Jul 2023 16:58:10 +0300 [thread overview]
Message-ID: <cef11e4e-d96e-8cc8-045c-adcf006bdcf0@arinc9.com> (raw)
In-Reply-To: <2a4da319-a78a-7cb1-6f18-f59180de779f@gmail.com>
On 29.07.2023 14:45, Rafał Miłecki wrote:
> Hi,
>
> I'm trying to understand MediaTek's Ethernet controller resets.
>
> I noticed there is sth fishy when checking dts files. See following
> errors:
>
> arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb:
> ethernet@1e100000: resets: [[2, 6], [2, 23]] is too short
> From schema:
> Documentation/devicetree/bindings/net/mediatek,net.yaml
> arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb:
> ethernet@1e100000: reset-names:1: 'gmac' was expected
> From schema:
> Documentation/devicetree/bindings/net/mediatek,net.yaml
> arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb:
> ethernet@1e100000: reset-names: ['fe', 'eth'] is too short
> From schema:
> Documentation/devicetree/bindings/net/mediatek,net.yaml
> arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb:
> ethernet@1e100000: Unevaluated properties are not allowed
> ('reset-names', 'resets' were unexpected)
> From schema:
> Documentation/devicetree/bindings/net/mediatek,net.yaml
Sigh, looks like this patch was applied regardless of my points here.
Now we're here picking up the pieces.
https://lore.kernel.org/netdev/b6c7462d-99fc-a8e1-1cc2-d0a1efc7c34d@arinc9.com/
>
>
> 1. Binding mediatek,net.yaml
> It says that when present, there must be 3 resets: fe, gmac, ppe
>
> 2. mt7621.dtsi
> It specifies 2 resets: fe, eth
>
> 3. mt7622.dtsi
> It doesn't specify any resets
>
> 4. mt7629.dtsi
> It doesn't specify any resets
>
> 5. drivers/net/ethernet/mediatek/
> I don't see any reset_control_* code at all
>
>
> Can someone help me what's the actual case with resets? Are they needed?
> Are they used?
I'm adding Sergio to CC as they've been the one working on this on
mt7621.dtsi.
There's relevant information here.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=64b2d6ffff862c0e7278198b4229e42e1abb3bb1
Arınç
next prev parent reply other threads:[~2023-07-29 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-29 11:45 MediaTek Frame Engine Ethernet: does it need any resets? Rafał Miłecki
2023-07-29 13:58 ` Arınç ÜNAL [this message]
2023-07-31 15:04 ` Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cef11e4e-d96e-8cc8-045c-adcf006bdcf0@arinc9.com \
--to=arinc.unal@arinc9.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel@makrotopia.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=sergio.paracuellos@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).