From: Florian Fainelli <f.fainelli@gmail.com>
To: Tristram.Ha@microchip.com, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
UNGLinuxDriver@microchip.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 net-next] net: phy: smsc: add WoL support to LAN8740/LAN8742 PHYs
Date: Mon, 24 Jul 2023 08:35:14 -0700 [thread overview]
Message-ID: <cf089185-4696-40ce-42c9-df2eea336d05@gmail.com> (raw)
In-Reply-To: <1689900053-13118-1-git-send-email-Tristram.Ha@microchip.com>
On 7/20/2023 5:40 PM, Tristram.Ha@microchip.com wrote:
> From: Tristram Ha <Tristram.Ha@microchip.com>
>
> Microchip LAN8740/LAN8742 PHYs support basic unicast, broadcast, and
> Magic Packet WoL. They have one pattern filter matching up to 128 bytes
> of frame data, which can be used to implement ARP or multicast WoL.
>
> ARP WoL matches any ARP frame with broadcast address.
>
> Multicast WoL matches any multicast frame.
>
> Signed-off-by: Tristram Ha <Tristram.Ha@microchip.com>
This looks good to me, just one suggestion but which you can implement
later, it would be nice to have a pm_wakeup_event(&phydev->mdio.dev, 0)
in order to have the PHY device accounted for any wake-up event. You can
do that when you do the initial acknowledgement of any wake-up
interrupts in your .config_init callback.
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
next prev parent reply other threads:[~2023-07-24 15:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 0:40 [PATCH v5 net-next] net: phy: smsc: add WoL support to LAN8740/LAN8742 PHYs Tristram.Ha
2023-07-24 11:50 ` Simon Horman
2023-07-24 15:35 ` Florian Fainelli [this message]
2023-07-24 23:43 ` Jakub Kicinski
2023-07-25 23:51 ` Tristram.Ha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf089185-4696-40ce-42c9-df2eea336d05@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).