From: Paolo Abeni <pabeni@redhat.com>
To: Jonas Gorski <jonas.gorski@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: fix VLAN 0 filter imbalance when toggling filtering
Date: Thu, 24 Apr 2025 11:15:41 +0200 [thread overview]
Message-ID: <cf0d5622-9b35-4a33-8680-2501d61f3cdf@redhat.com> (raw)
In-Reply-To: <20250422184913.20155-1-jonas.gorski@gmail.com>
On 4/22/25 8:49 PM, Jonas Gorski wrote:
> When a net device has NETIF_F_HW_VLAN_CTAG_FILTER set, the 8021q code
> will add VLAN 0 when enabling the device, and remove it on disabling it
> again.
>
> But since we are changing NETIF_F_HW_VLAN_CTAG_FILTER during runtime in
> dsa_user_manage_vlan_filtering(), user ports that are already enabled
> may end up with no VLAN 0 configured, or VLAN 0 left configured.
Why this is a problem specifically for dsa and not a generic one? others
devices allow flipping the NETIF_F_HW_VLAN_CTAG_FILTER feature at runtime.
AFAICS dsa_user_manage_vlan_filtering() is currently missing a call to
netdev_update_features(), why is that not sufficient nor necessary?
Thanks,
Paolo
next prev parent reply other threads:[~2025-04-24 9:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 18:49 [PATCH net] net: dsa: fix VLAN 0 filter imbalance when toggling filtering Jonas Gorski
2025-04-24 9:15 ` Paolo Abeni [this message]
2025-04-24 9:50 ` Jonas Gorski
2025-04-25 7:30 ` Jonas Gorski
2025-04-25 7:51 ` Vladimir Oltean
2025-04-26 15:48 ` Jonas Gorski
2025-04-28 9:02 ` Vladimir Oltean
2025-04-24 10:25 ` Vladimir Oltean
2025-04-24 12:34 ` Florian Fainelli
2025-04-24 13:58 ` Jonas Gorski
2025-04-24 22:57 ` Vladimir Oltean
2025-04-25 7:52 ` Jonas Gorski
2025-04-25 11:42 ` Vladimir Oltean
2025-04-26 15:44 ` Jonas Gorski
2025-04-28 9:27 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf0d5622-9b35-4a33-8680-2501d61f3cdf@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=horms@kernel.org \
--cc=jonas.gorski@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox