From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18BE073161 for ; Thu, 14 Mar 2024 15:26:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710429963; cv=none; b=gxiHg2WhjDF+C8KTCFSvyz7jp3/imO7MJAHNpuV05XfI0SSwRThsxGrFLVP/VglqlC1tfcQjOn+yEBc0JT5JBAxhJoU4U+4oR2JH1dloQyKd6RnNXJZc7miVhmrWwnhKoeAxmbmFAZ904jEirkWRVMioWeqj9cyT6A3xXKrtciI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710429963; c=relaxed/simple; bh=8cvKr7d4NQMD6rV5ICNWjJFCc9Rn5GqEyfYezZ8FfXE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bC+actXJpfYp9lWN+YoJhWO6CNfDbIEYUGXW6F3WfqlH961h64tPCGORFcACQ0U/duF7ElqaY05MKurw63aO1NQinX9DTDu6Y5VgCx+i7Y31wb7YdH66MjaOruLd9oMmfuxHkuA4Rv+b61XnfyESRlJ7ooFKvMMi+lmMEARHX7s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OFMmTrUF; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OFMmTrUF" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a45ecef71deso124016366b.2 for ; Thu, 14 Mar 2024 08:26:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710429959; x=1711034759; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NB+5mrq0PxIelZvARbna34D3J9n3SotqWPlIkWyzZ7g=; b=OFMmTrUFfImhrqJwMv2Xbp/intiVqvkg2JMCj2zx9GRXzxhjD95YwjFFlUwxUA6J4e IaRQ5YnkYj3rSE85sh4OpSuJjze8rmUXNc8IWNVCZJ/QsdT/Y8ioMmx1r2vdMKPeC2Nj tbCL09pedGZecHQDFktXRqVxJgu/BSnKjqmp7aNvaMUgWfeyw0zqamVRoekoeVnvHp5s cv7kBcr+8/1BQls1UWJ+TduqzG8z0lc9MQ+sPiA3IgH62DaSPzoNZaOi/MB9ihpfO8Gq wID2l2BKaboP2yr8ar54GkTV7cJNyXZMQ5GQNN44RxjwjFt8dRuZ2Ei1xhew+llgxOsB /Glg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710429959; x=1711034759; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NB+5mrq0PxIelZvARbna34D3J9n3SotqWPlIkWyzZ7g=; b=nZmkblvn4YKhcPkM6Y1pWY7ww9j58iJ7Jl53CzBeKKFMCWBl2Ufjwzx74s4jH+g2w3 KPGew53IW0G+AvZY/cDzV0STrNXTkSl9vDabZdHj+wdFo3rLSSkC8Qmq+LaaOPIjW/Ek cDM9c7O9Fwd2VbLKLYQPucsbKGX2qFMpDExZ8C7o34fMEh5lUozOhhGK6kPncUeDqtuX Tl0meUmjmC4MFUHbXIXIPvav8WZ8MI5kPqYjNwCNeTk5Il/+1+pM2/0AUUhvVmmVIw+5 3G+5gVvh7nb0fWa3400uYwiAjMbeccJLJO2L4VcxtTfJxid8n9q65bDaWzw6bOmPLIj+ CfZg== X-Gm-Message-State: AOJu0Yy/1p6vD/4r92dhRR+Z0JCd1Rf52s0ITHjdp1e8nfcgjOD1jwuQ M9UOJZsoF/7WWzBwRIfrLi49MgcspNnZCh7JKxT1IT8mSI0ubEG+OCUrs7RdhW4= X-Google-Smtp-Source: AGHT+IGSSGhGzEqt6ZAz8E1tBdEiggEdCHPDZVKPnOsOt3CpRBMuZZV8Ang70Vdpxd4OZv73roliFw== X-Received: by 2002:a17:907:8dcc:b0:a46:7509:2425 with SMTP id tg12-20020a1709078dcc00b00a4675092425mr1446619ejc.63.1710429959482; Thu, 14 Mar 2024 08:25:59 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id jx25-20020a170907761900b00a4661f0f1e7sm793952ejc.205.2024.03.14.08.25.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Mar 2024 08:25:59 -0700 (PDT) Message-ID: Date: Thu, 14 Mar 2024 16:25:55 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] dt-bindings: net: add new property st,ext-phyclk in documentation for stm32 Content-Language: en-US To: Christophe ROULLIER , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Jose Abreu , Liam Girdwood , Mark Brown Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240307135957.303481-1-christophe.roullier@foss.st.com> <20240307135957.303481-3-christophe.roullier@foss.st.com> <578f421c-ca06-45d4-8380-8b2b423d4d47@linaro.org> <50ee6122-b160-48ea-8c44-1046b5907d7c@foss.st.com> <51531046-ee83-4d99-836b-af4dc5d7add9@foss.st.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <51531046-ee83-4d99-836b-af4dc5d7add9@foss.st.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 14/03/2024 16:10, Christophe ROULLIER wrote: > Hi, > > On 3/13/24 14:06, Krzysztof Kozlowski wrote: >> On 13/03/2024 11:39, Christophe ROULLIER wrote: >>> On 3/8/24 09:28, Krzysztof Kozlowski wrote: >>>> On 07/03/2024 14:59, Christophe Roullier wrote: >>>>> Add property st,ext-phyclk to manage cases when PHY have no cristal/quartz >>>>> This property can be used with RMII phy without cristal 50Mhz and when we >>>>> want to select RCC clock instead of ETH_REF_CLK >>>>> Can be used also with RGMII phy with no cristal and we select RCC clock >>>>> instead of ETH_CLK125 >>>>> >>>> Nothing improved here. You say you add new property (wrote it explicitly >>>> in the subject), but where is it? Where is the user? >>>> >>>> I think we talked about this. Rob also asked quite clear: >>>> >>>>> That is obvious from the diff. What is not obvious is why we need a new >>>>> property and what is the problem with the existing ones. >>>> How did you solve it? >>> Hi, >>> >>> I do not understand your questions. >> OK, I will clarify some questions, but are you sure that this question: >> "How did you solve it?" >> needs clarification? >> >> If so, then let me clarify: >> Rob pointed issue. How did you resolve Rob's comment? How did you >> address it? What changed in your patch, that Rob's comment should be >> considered as addressed/resolved/done? > This property was introduced in 2020 in order to simplify management of > all STM32 platforms without Ethernet cristal/quartz PHY. I fail to see how this answers how did you resolve the comment. You now described some sort of history, but I am asking: what did you change in your patches, so Rob's comment is considered resolved? >> >> Now about my other question: >> "but where is it? Where is the user?" >> >> Your subject and commit message claim you add new property. This means >> such property was not existing so far in the Linux kernel. If you add >> new property in the binding, then I expect adding the user of that >> binding, thus my question: where is the user of that binding? >> > I'm preparing glue and DTS to upstream for STM32MP13 platform, this > platform will use with property. > > Since 2020, this property is available in the driver in kernel.org, so > it is also possible that someone who has not upstreamed their This should be explained in commit msg (although not kernel.org, website does not matter here). > > code also uses it. > >>> That I would like to do, it is property "st,ext-phyclk" was introduced >>> in driver >>> >>> "drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c" in 2020, and YAML >>> was not updated at the time. >> Are you saying you document existing property or add a new one? > Yes, existing property, since 2020 in kernel.org. Drop the website. We talk here about Linux kernel. Commit msg fails to explain it in a clear way. >> >>> Goal of this patch it is to update YAML to avoid dtbs check issue if >>> someone use this property : >>> >>> dtbs check issue : views/kernel/upstream/net-next/arch/arm/boot/dts/st/stm32mp157c-dk2.dtb: >>> ethernet@5800a000: Unevaluated properties are not allowed >>> ('st,ext-phyclk' was unexpected) >> So DTS uses it? > Here it was example, if someone wants to use this property, but today > this property is not yet present in DTS in kernel.org Best regards, Krzysztof