From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793896560; b=3MxJePvqET/rKF8sWWlCZX9rmV+WdUC1Ei6/fJ7fpu1ckNpGUgTqJf1P/ojunVFIfnp+ XzGoDYCD1B0aqqN633mfkTYCkBPZcpbkfyXIDpEEJur61lQIxSy5u17Yx9aT8rrjIxK20 PW9KMraFP9xlKN/GlTy7sRSJPIEOjxRg6H6E5NV8wmwcT/byD9GfLGYrzTTjOdIutvx94 e3KXXN+rTe81gj/25AcZQY9Ttmlm9aXWC57oKIc9E7W3xXX1pJ9+8LNU5Q33STQHGfikn SFkw5iQ3A95NncLJniYBtw1zewO5lLc+k3ag776pfRCx1rBkbk9GQJha8r3FWtZglrA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793896560; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=oaFEybmB3/LpRlTwU2ESXZoM0QOYsoH22CakPe6LiW0=; b=WKUB0QkMDAn4Vx0wTnBZ7LmLyjIx4d4hxvqXsqBN8XLGM4b2Jld6Vsm6aIMWjYbJicMj JAu+fOlyxtr0fjWKmqdqJ8Liut5/DRaZ9nUMASWNenp8OV+CNBzSAyTJd5ObFDizc8PvI 9VxYJehL+tuYpptGJwBatIC6vXTZSZZ4aJZ0u7gZ3f7WkoCU5dnjLGnmoh3bVAx7ONEAa 2Q6O3+ILeX3aN+4QXNESuBl0J0op9azPpNDxLi8p9vODc52vRlO0rqmG6RRCQyzO2CvIN eMqbwT3T1XMjZQ6om2s//oqrnrB2N1Oru+yc9zth1iR9J+llMoq3oGyVJ2ADuOrSupQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b="PpT8/D5z"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D52B606A33F; Thu, 5 Nov 2026 16:35:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=PpT8/D5z Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10A1A1F000C1; Thu, 5 Nov 2026 16:35:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793896559; bh=oaFEybmB3/LpRlTwU2ESXZoM0QOYsoH22CakPe6LiW0=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=PpT8/D5zeLlfhjXRHDS9Xn7yTDCLEhyyWpMkM0/IfblI9PMLXcKedSOlnoASybHch QMV8ab3TA2uSLtQsY231ygXHLK4E1dZjZWYTUyaq5EG+U+7SRxv/SC5EV5zIEGfbl+ Anl6FvxIWk2bzbUyorgGwbK7QtWE0eneo9Vkb0oEtRPqNHIcsTwj/H9gaUxgdyQRKl 9la8Ee4KQAzAUk3BDbj8WwQQ1UKgW36gLtWALpg8W7Mm455sUJQJK7b75HwOTlAxFH tWWXsXG7Et2NnPPdGnHQoyRFRfRXjPc/WvDrWcLkNmwuDZMfzvcAqJShtCN7KTNjC+ ltbn1tD2mVL7w== Message-ID: Date: Thu, 5 Nov 2026 17:35:34 +0100 X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v1 0/5] net: deprecate skb->pp_recycle and skb_mark_for_recycle() To: Mina Almasry , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, linux-mm@kvack.org, bpf@vger.kernel.org, linux-wireless@vger.kernel.org, linux-doc@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, imx@lists.linux.dev, linux-rdma@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-omap@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Steffen Klassert , Herbert Xu , Willem de Bruijn , Stanislav Fomichev , Pavel Begunkov , Bobby Eshleman , Andrew Lunn , "Michael S. Tsirkin" , Jason Wang , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Xuan Zhuo , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Ilias Apalodimas , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Sabrina Dubroca , Johannes Berg , Byungchul Park , Jonathan Corbet , Shuah Khan , Randy Dunlap , Lorenzo Bianconi , Wen Gu , Philo Lu , Justin Chen , Florian Fainelli , Vikas Gupta , Michael Chan , Pavan Chebbi , Doug Berger , Nicolai Buchwitz , Satish Kharat , Wei Fang , Frank Li , Shenwei Wang , Joshua Washington , Harshitha Ramamurthy , Jijie Shao , Jian Shen , Fan Gong , Tony Nguyen , Przemek Kitszel , Marcin Wojtas , Russell King , Sunil Goutham , Geetha sowjanya , Ratheesh Kannoth , Subbaraya Sundeep , Bharat Bhushan , Felix Fietkau , Matthias Brugger , AngeloGioacchino Del Regno , Tariq Toukan , Saeed Mahameed , Mark Bloch , Leon Romanovsky , Ido Schimmel , Petr Machata , Horatiu Vultur , UNGLinuxDriver@microchip.com, Daniel Machon , Steen Hegelund , Haiyang Zhang , Wei Liu , Dexuan Cui , Yibo Dong , Brett Creeley , Justin Lai , Larry Chiu , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Paul Barker , Masahisa Kojima , Maxime Chevallier , Maxime Coquelin , Alexandre Torgue , FUJITA Tomonori , Siddharth Vadapalli , Roger Quadros , MD Danish Anwar , Jiawen Wu , Mengyuan Lou , Ronak Doshi , Ryder Lee , Shayne Chen , Sean Wang , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jordan Rhee , Ankit Garg , Tim Hostetler , Erni Sri Satya Vennela , Eric Joyner , Mohammad Heib , Prabu Thayalan , Chintan Vankar , Nora Schiffer , Alexander Sverdlin , Kevin Hao , Karl Mehltretter , Aleksandr Loktionov , Meghana Malladi , Jacob Keller , StanleyYP Wang References: <20261103211424.127627-1-almasrymina@google.com> Content-Language: en-US From: Jesper Dangaard Brouer In-Reply-To: <20261103211424.127627-1-almasrymina@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/3/26 22:14, Mina Almasry wrote: > Remove the per-SKB skb->pp_recycle bitfield and skb_mark_for_recycle() > helper, and reference-count netmems directly by their underlying type > via netmem_is_pp() inside netmem_inc_ref() and netmem_dec_ref(). > > This series simplifies SKB and netmem reference counting: > - Reclaims 1 bit from struct sk_buff (skb->pp_recycle). > - Unifies reference counting of SKB fragment netmems and regular netmems > under netmem_inc_ref() and netmem_dec_ref(), eliminating the separate > skb_netmem_ref(), skb_netmem_unref(), and skb_mark_for_recycle() APIs. Part of the performance gain from page_pool was to completely avoid the atomic refcnt operation, when we can see that page refcnt==1. Are you removing this? > - Removes 110 net lines of non-test/doc code across 63 files (196 > insertions, 306 deletions). > > 1/5: net: skbuff: skip managed zerocopy frags in skb_frag_ref() > 2/5: net: skbuff: refcount spliced page_pool frags via skb_pipe_buf_ops > 3/5: net: datagram: refcount page_pool frags in zerocopy_fill_skb_from_iter() > 4/5: net: remove skb->pp_recycle and consolidate netmem refcounting > 5/5: net: remove skb_mark_for_recycle() > > Mina Almasry (5): > net: skbuff: skip managed zerocopy frags in skb_frag_ref() > net: skbuff: refcount spliced page_pool frags via skb_pipe_buf_ops > net: datagram: refcount page_pool frags in > zerocopy_fill_skb_from_iter() > net: remove skb->pp_recycle and consolidate netmem refcounting > net: remove skb_mark_for_recycle() > > Documentation/networking/page_pool.rst | 1 - > drivers/net/ethernet/airoha/airoha_eth.c | 1 - > drivers/net/ethernet/alibaba/eea/eea_rx.c | 3 - > .../net/ethernet/broadcom/asp2/bcmasp_intf.c | 1 - > .../net/ethernet/broadcom/bnge/bnge_txrx.c | 5 - > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 - > .../net/ethernet/broadcom/genet/bcmgenet.c | 2 - > drivers/net/ethernet/cisco/enic/enic_rq.c | 1 - > drivers/net/ethernet/engleder/tsnep_main.c | 2 - > drivers/net/ethernet/freescale/fec_main.c | 1 - > drivers/net/ethernet/google/gve/gve_rx_dqo.c | 9 - > .../net/ethernet/hisilicon/hibmcge/hbg_txrx.c | 1 - > .../net/ethernet/hisilicon/hns3/hns3_enet.c | 6 - > .../net/ethernet/huawei/hinic3/hinic3_rx.c | 1 - > drivers/net/ethernet/intel/iavf/iavf_txrx.c | 2 - > drivers/net/ethernet/marvell/mvneta.c | 2 - > .../net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 - > .../marvell/octeontx2/nic/otx2_txrx.c | 1 - > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 - > drivers/net/ethernet/mellanox/mlx4/en_rx.c | 1 - > .../net/ethernet/mellanox/mlx5/core/en_rx.c | 8 - > drivers/net/ethernet/mellanox/mlxsw/pci.c | 2 - > .../ethernet/microchip/lan966x/lan966x_fdma.c | 2 - > .../microchip/sparx5/lan969x/lan969x_fdma.c | 1 - > drivers/net/ethernet/microsoft/mana/mana_en.c | 3 - > .../net/ethernet/mucse/rnpgbe/rnpgbe_lib.c | 1 - > .../net/ethernet/pensando/ionic/ionic_txrx.c | 2 - > .../net/ethernet/realtek/rtase/rtase_main.c | 1 - > drivers/net/ethernet/renesas/ravb_main.c | 2 - > drivers/net/ethernet/socionext/netsec.c | 1 - > .../net/ethernet/stmicro/stmmac/stmmac_main.c | 1 - > drivers/net/ethernet/tehuti/tn40.c | 1 - > drivers/net/ethernet/ti/am65-cpsw-nuss.c | 1 - > drivers/net/ethernet/ti/cpsw.c | 2 - > drivers/net/ethernet/ti/cpsw_new.c | 2 - > drivers/net/ethernet/ti/icssg/icssg_common.c | 1 - > drivers/net/ethernet/wangxun/libwx/wx_lib.c | 2 - > drivers/net/veth.c | 3 +- > drivers/net/virtio_net.c | 16 +- > drivers/net/vmxnet3/vmxnet3_xdp.c | 1 - > drivers/net/wireless/mediatek/mt76/dma.c | 1 - > .../net/wireless/mediatek/mt76/mt7996/mac.c | 1 - > drivers/net/wireless/mediatek/mt76/npu.c | 1 - > drivers/net/wireless/mediatek/mt76/usb.c | 1 - > drivers/net/xen-netfront.c | 1 - > include/linux/mm.h | 2 +- > include/linux/skbuff.h | 12 +- > include/linux/skbuff_ref.h | 60 +-- > include/net/netmem.h | 39 +- > include/net/page_pool/helpers.h | 46 ++- > net/core/datagram.c | 5 + > net/core/gro.c | 9 - > net/core/net_test.c | 369 +++++++++++------- > net/core/netmem_priv.h | 23 +- > net/core/page_pool.c | 8 +- > net/core/skbuff.c | 78 ++-- > net/core/xdp.c | 13 +- > net/ipv4/esp4.c | 11 +- > net/ipv6/esp6.c | 11 +- > net/tls/tls_device.c | 14 +- > net/tls/tls_device_fallback.c | 6 +- > net/tls/tls_main.c | 4 +- > net/wireless/util.c | 31 +- > net/xfrm/trace_iptfs.h | 6 +- > net/xfrm/xfrm_iptfs.c | 16 +- > 65 files changed, 418 insertions(+), 454 deletions(-) > > > base-commit: 7b6ab4dbc156e2f96419715130b3d5738a306c93