From: "Csókás Bence" <csokas.bence@prolan.hu>
To: Francesco Dolcini <francesco.dolcini@toradex.com>
Cc: <netdev@vger.kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
<kernel@pengutronix.de>, Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: [PATCH v2] net: fec: Use a spinlock to guard `fep->ptp_clk_on`
Date: Fri, 2 Sep 2022 09:18:48 +0200 [thread overview]
Message-ID: <cf2f3ba9-c4fa-1618-f795-9a27b065ef56@prolan.hu> (raw)
In-Reply-To: <20220901150416.GA1237970@francesco-nb.int.toradex.com>
On 2022. 09. 01. 17:04, Francesco Dolcini wrote:
> On Thu, Sep 01, 2022 at 04:04:03PM +0200, Csókás Bence wrote:
>> Mutexes cannot be taken in a non-preemptible context,
>> causing a panic in `fec_ptp_save_state()`. Replacing
>> `ptp_clk_mutex` by `tmreg_lock` fixes this.
>>
>> Fixes: 6a4d7234ae9a ("net: fec: ptp: avoid register access when ipg clock is disabled")
> This should be removed, there was no issue with just this commit. Am I
> wrong?
>
> One of the reasons of the Fixes tag is to backport to stable releases,
> and you do not want this commit in 5.15.x.
I do want it, actually, because I got a PATCH AUTOSEL already for
f79959220fa5fbda939592bf91c7a9ea90419040 for 5.15 & 5.19, but I told
them not to backport until this fix is merged too.
Bence
next prev parent reply other threads:[~2022-09-02 7:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 14:04 [PATCH v2] net: fec: Use a spinlock to guard `fep->ptp_clk_on` Csókás Bence
2022-09-01 15:04 ` Francesco Dolcini
2022-09-02 7:18 ` Csókás Bence [this message]
2022-09-01 16:26 ` Florian Fainelli
2022-09-02 7:35 ` Csókás Bence
2022-09-02 15:47 ` Florian Fainelli
2022-09-02 17:04 ` Francesco Dolcini
2022-09-03 4:30 ` patchwork-bot+netdevbpf
2022-09-05 7:38 ` Marc Kleine-Budde
2022-09-07 14:39 ` Marc Kleine-Budde
2022-09-09 13:56 ` Francesco Dolcini
2022-09-10 17:08 ` Csókás Bence
2022-09-14 14:53 ` [REGRESSION] " Guenter Roeck
2022-09-18 18:59 ` [REGRESSION] Re: [PATCH v2] net: fec: Use a spinlock to guard `fep->ptp_clk_on` #forregzbot Thorsten Leemhuis
2022-09-22 10:58 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf2f3ba9-c4fa-1618-f795-9a27b065ef56@prolan.hu \
--to=csokas.bence@prolan.hu \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=francesco.dolcini@toradex.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).