* [PATCH] can: ems_usb: Fix memory leak on ems_usb_disconnect
@ 2018-07-27 15:50 Anton Vasilyev
2018-07-30 9:09 ` Marc Kleine-Budde
0 siblings, 1 reply; 2+ messages in thread
From: Anton Vasilyev @ 2018-07-27 15:50 UTC (permalink / raw)
To: Wolfgang Grandegger
Cc: Anton Vasilyev, Marc Kleine-Budde, David S. Miller, Martin Kelly,
Martin Lederhilger, linux-can, netdev, linux-kernel, ldv-project
ems_usb_probe() allocates memory for dev->tx_msg_buffer, but there
is no its deallocation in ems_usb_disconnect.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
---
drivers/net/can/usb/ems_usb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/can/usb/ems_usb.c b/drivers/net/can/usb/ems_usb.c
index 12ff0020ecd6..b7dfd4109d24 100644
--- a/drivers/net/can/usb/ems_usb.c
+++ b/drivers/net/can/usb/ems_usb.c
@@ -1072,6 +1072,7 @@ static void ems_usb_disconnect(struct usb_interface *intf)
usb_free_urb(dev->intr_urb);
kfree(dev->intr_in_buffer);
+ kfree(dev->tx_msg_buffer);
}
}
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] can: ems_usb: Fix memory leak on ems_usb_disconnect
2018-07-27 15:50 [PATCH] can: ems_usb: Fix memory leak on ems_usb_disconnect Anton Vasilyev
@ 2018-07-30 9:09 ` Marc Kleine-Budde
0 siblings, 0 replies; 2+ messages in thread
From: Marc Kleine-Budde @ 2018-07-30 9:09 UTC (permalink / raw)
To: Anton Vasilyev, Wolfgang Grandegger
Cc: David S. Miller, Martin Kelly, Martin Lederhilger, linux-can,
netdev, linux-kernel, ldv-project
[-- Attachment #1.1: Type: text/plain, Size: 610 bytes --]
On 07/27/2018 05:50 PM, Anton Vasilyev wrote:
> ems_usb_probe() allocates memory for dev->tx_msg_buffer, but there
> is no its deallocation in ems_usb_disconnect.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
Applied to linux-can.
Tnx,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-30 10:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-27 15:50 [PATCH] can: ems_usb: Fix memory leak on ems_usb_disconnect Anton Vasilyev
2018-07-30 9:09 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).