From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
"Loktionov, Aleksandr" <aleksandr.loktionov@intel.com>
Cc: Chenguang Zhao <chenguang.zhao@linux.dev>,
"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Chenguang Zhao <zhaochenguang@kylinos.cn>
Subject: Re: [Intel-wired-lan] [PATCH net] i40e: xsk: fix multi-buffer XDP_PASS skb construction
Date: Thu, 16 Jul 2026 11:15:45 -0700 [thread overview]
Message-ID: <cf4f79e7-412b-40b6-81a5-f32ef3522bc1@intel.com> (raw)
In-Reply-To: <ald07ZVc7Z/NLXcm@boxer>
On 7/15/2026 4:54 AM, Maciej Fijalkowski wrote:
...
> We could go with this as-is, right, but given we have a helper available
> to do exactly what this patch touches, I think we could kill two birds
> with one stone by removing home-grown code. However one might argue that
> such change is a -next material.
I agree with trying to utilize the helper here. I don't see a need to
try and fix a home grown implementation when a working helper already
exists.
Thanks,
Tony
prev parent reply other threads:[~2026-07-16 18:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 2:51 [PATCH net] i40e: xsk: fix multi-buffer XDP_PASS skb construction Chenguang Zhao
2026-07-14 13:07 ` Maciej Fijalkowski
2026-07-15 9:37 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-07-15 11:54 ` Maciej Fijalkowski
2026-07-16 18:15 ` Tony Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf4f79e7-412b-40b6-81a5-f32ef3522bc1@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=chenguang.zhao@linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=zhaochenguang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox