netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	David Miller <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: support in-band signalling with external PHY for 1000BaseX/2500BaseX
Date: Sat, 2 Mar 2019 21:36:01 +0100	[thread overview]
Message-ID: <cf646fdf-d50f-02b2-b271-732713857fb6@gmail.com> (raw)
In-Reply-To: <dd84d667-ecc6-046d-00e3-9205fa8ec2bd@gmail.com>

On 02.03.2019 21:34, Heiner Kallweit wrote:
> On 02.03.2019 21:13, Andrew Lunn wrote:
>> On Sat, Mar 02, 2019 at 04:57:32PM +0100, Heiner Kallweit wrote:
>>> Propagate the external PHY settings also in 1000BaseX and
>>> 2500BaseX mode.
>>
>> Hi Heiner
>>
> Hi Andrew
> 
>> I don't think this is needed. 1000BaseX and 2500BaseX does not support
>> inband signalling. So the mac_config() call for these modes should
>> include the needed speed configuration. I've used 1000BaseX with an
>> SFP and there was no need to configure anything.
>>
What I forgot: I can't explain why your SFP use case works. Was it also
with this Marvell switch? 

> 1000BaseX and 2500BaseX use 802.3z Clause 37 inband auto-neg. From what
> I've read 1000BaseT is an extension of it.
> My understanding is that w/o such inband signalling we had no chance
> to detect a "link up" situation. All we could detect is: serial connection
> is synced. Also my understanding is that the ACK to this inband signalling
> triggers the "link up" interrupt.
> 
> Here I found something:
> http://www.methode.com/Documents/TechnicalLibrary/SFP_Ethernet_Auto_Negotiation.pdf
> 
> I briefly looked at the SFP connector and there don't seem to be pins for
> out-of-band signalling. So there must be some inband signalling.
> 
>>     Andrew
>>
> Heiner
> 
Heiner

  reply	other threads:[~2019-03-02 20:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-02 15:57 [PATCH net-next] net: dsa: mv88e6xxx: support in-band signalling with external PHY for 1000BaseX/2500BaseX Heiner Kallweit
2019-03-02 20:13 ` Andrew Lunn
2019-03-02 20:34   ` Heiner Kallweit
2019-03-02 20:36     ` Heiner Kallweit [this message]
2019-03-02 20:45     ` Andrew Lunn
2019-03-02 21:03       ` Heiner Kallweit
2019-03-04 18:54 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf646fdf-d50f-02b2-b271-732713857fb6@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).