From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC5B3C43381 for ; Sat, 2 Mar 2019 20:36:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 652E62086D for ; Sat, 2 Mar 2019 20:36:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qg0bJrRo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726610AbfCBUgK (ORCPT ); Sat, 2 Mar 2019 15:36:10 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:34451 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726497AbfCBUgK (ORCPT ); Sat, 2 Mar 2019 15:36:10 -0500 Received: by mail-wr1-f65.google.com with SMTP id f14so1387453wrg.1 for ; Sat, 02 Mar 2019 12:36:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=sd7agODxXb+rnRqUMraD4ZdaeJQbqHuyUP37iOAJTL4=; b=qg0bJrRoplzKV3iF1hTpIcOIMyXnL50rHjFHT71FJFngd36br8WDCwhBpB+LwOCTRy QJqAAK8Np6w0Jw2QfFEhzm5iMiA9ysecE60RSeNC4g3q3VAVuvoWq20NGr+aKsrBXVoS 67TfDHWvsenN4I2xEwcYQ0jOeer4IQIHkS20pslxn2XBfGgh/shBiKEejr0czCliI69i Byt3y1ihsjpayceyxBtRd1poD5AXxSYdwWUGGpMfAq8ytckYgfdGwgiwHE0kh2WC9ycT GEUHPPpvC4wn4xiNiNSxoox6PCTKdWx0wbQSFG5LMymgDZXMUQijPudHHgk5plKgd9ux +s0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sd7agODxXb+rnRqUMraD4ZdaeJQbqHuyUP37iOAJTL4=; b=mBseT3IVC9+btvSfVISYR7b2/hC4Gqq569vAU2RPfgDh3EZg7YS6y5YESTGUTLJ61a R0fWn1YCU7ADTht3f+8f+voDQARUVV7EIQO691NiA7zzYR/MFc1m33N5oagmpT3MvmGl ID/MldGWp5nufgU5zv/CuwaankaMpIctoPH+8u3eKk/LVBoWUnpeKrfHnx+YLIbZ2T01 sCI7rd0U1Mzv89fGLLkuErvwQTgnrh+yGhBuhjbwOZhGur6UPRfL0ipsYZL92L+E1zyC SiuuKDxCGcwBPX6Jt7eJ97ZVaPsfcsvUdTtEgTdADjmKw/BJF/JDIZ5tws1E+SvGZOC3 FK+g== X-Gm-Message-State: APjAAAVYgtHhp9LcKGbX8F2OPtwip/UdxnsGxCrJ9MrRi2kWRJRQL8/I 4hrVWmp0A7KAsBZFu/MHR7PX8/bQ X-Google-Smtp-Source: APXvYqzXeolQMBrXFyaYRJ8XIdIplQ8ouyr/NJc8A6J4KRx4imPFMkuNrC93NX0RuaMIl4WliNBzCg== X-Received: by 2002:adf:e48a:: with SMTP id i10mr8023615wrm.257.1551558968726; Sat, 02 Mar 2019 12:36:08 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:ed04:ce8:ead3:a1ec? (p200300EA8BF1E200ED040CE8EAD3A1EC.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:ed04:ce8:ead3:a1ec]) by smtp.googlemail.com with ESMTPSA id o12sm6763582wre.0.2019.03.02.12.36.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 Mar 2019 12:36:08 -0800 (PST) Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: support in-band signalling with external PHY for 1000BaseX/2500BaseX From: Heiner Kallweit To: Andrew Lunn Cc: Vivien Didelot , Florian Fainelli , David Miller , "netdev@vger.kernel.org" References: <20190302201307.GA10359@lunn.ch> Message-ID: Date: Sat, 2 Mar 2019 21:36:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 02.03.2019 21:34, Heiner Kallweit wrote: > On 02.03.2019 21:13, Andrew Lunn wrote: >> On Sat, Mar 02, 2019 at 04:57:32PM +0100, Heiner Kallweit wrote: >>> Propagate the external PHY settings also in 1000BaseX and >>> 2500BaseX mode. >> >> Hi Heiner >> > Hi Andrew > >> I don't think this is needed. 1000BaseX and 2500BaseX does not support >> inband signalling. So the mac_config() call for these modes should >> include the needed speed configuration. I've used 1000BaseX with an >> SFP and there was no need to configure anything. >> What I forgot: I can't explain why your SFP use case works. Was it also with this Marvell switch? > 1000BaseX and 2500BaseX use 802.3z Clause 37 inband auto-neg. From what > I've read 1000BaseT is an extension of it. > My understanding is that w/o such inband signalling we had no chance > to detect a "link up" situation. All we could detect is: serial connection > is synced. Also my understanding is that the ACK to this inband signalling > triggers the "link up" interrupt. > > Here I found something: > http://www.methode.com/Documents/TechnicalLibrary/SFP_Ethernet_Auto_Negotiation.pdf > > I briefly looked at the SFP connector and there don't seem to be pins for > out-of-band signalling. So there must be some inband signalling. > >> Andrew >> > Heiner > Heiner