From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Randy Dunlap <rdunlap@infradead.org>, netdev@vger.kernel.org
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
"Johannes Berg" <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath9k: debug.h: fix kernel-doc bad lines and struct ath_tx_stats
Date: Wed, 14 Jan 2026 07:53:06 -0800 [thread overview]
Message-ID: <cf6b81ea-3ab2-420a-ac10-e847be54c9c3@oss.qualcomm.com> (raw)
In-Reply-To: <20251117020304.448687-1-rdunlap@infradead.org>
On 11/16/2025 6:03 PM, Randy Dunlap wrote:
> Repair "bad line" warnings by starting each line with " *".
> Add or correct kernel-doc entries for missing struct members in
> struct ath_tx_stats.
>
> Warning: ../drivers/net/wireless/ath/ath9k/debug.h:144 bad line:
> may have had errors.
> Warning: ../drivers/net/wireless/ath/ath9k/debug.h:146 bad line:
> may have had errors.
> Warning: ../drivers/net/wireless/ath/ath9k/debug.h:156 bad line:
> Valid only for:
> Warning: ../drivers/net/wireless/ath/ath9k/debug.h:157 bad line:
> - non-aggregate condition.
> Warning: ../drivers/net/wireless/ath/ath9k/debug.h:158 bad line:
> - first packet of aggregate.
> Warning: drivers/net/wireless/ath/ath9k/debug.h:191 struct member
> 'xretries' not described in 'ath_tx_stats'
> Warning: drivers/net/wireless/ath/ath9k/debug.h:191 struct member
> 'data_underrun' not described in 'ath_tx_stats'
> Warning: drivers/net/wireless/ath/ath9k/debug.h:191 struct member
> 'delim_underrun' not described in 'ath_tx_stats'
>
> Fixes: 99c15bf575b1 ("ath9k: Report total tx/rx bytes and packets in debugfs.")
> Fixes: fec247c0d5bf ("ath9k: Add debug counters for TX")
> Fixes: 5a6f78afdabe ("ath9k: show excessive-retry MPDUs in debugfs")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Toke Høiland-Jørgensen <toke@toke.dk>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: linux-wireless@vger.kernel.org
I'm picking this up, but my automation noticed there are still kdoc issues:
Warning: drivers/net/wireless/ath/ath9k/debug.h:138 struct member 'txeol' not described in 'ath_interrupt_stats'
...
Warning: drivers/net/wireless/ath/ath9k/debug.h:138 struct member 'mac_sleep_access' not described in 'ath_interrupt_stats'
19 warnings as errors
Are these handled elsewhere, or will they need to be handled later?
/jeff
next prev parent reply other threads:[~2026-01-14 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 2:03 [PATCH] ath9k: debug.h: fix kernel-doc bad lines and struct ath_tx_stats Randy Dunlap
2025-11-17 11:35 ` Toke Høiland-Jørgensen
2026-01-14 15:53 ` Jeff Johnson [this message]
2026-01-14 19:15 ` Randy Dunlap
2026-01-16 1:26 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf6b81ea-3ab2-420a-ac10-e847be54c9c3@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox