From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH iproute2-next] tc: Correct json output for actions Date: Wed, 4 Apr 2018 11:13:32 -0600 Message-ID: References: <1522844653-37136-1-git-send-email-yuvalm@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: mlxsw@mellanox.com, netdev@vger.kernel.org, Stephen Hemminger , Roman Mashak To: Yuval Mintz Return-path: Received: from mail-pl0-f53.google.com ([209.85.160.53]:39403 "EHLO mail-pl0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752424AbeDDRNe (ORCPT ); Wed, 4 Apr 2018 13:13:34 -0400 Received: by mail-pl0-f53.google.com with SMTP id s24-v6so14937634plq.6 for ; Wed, 04 Apr 2018 10:13:34 -0700 (PDT) In-Reply-To: <1522844653-37136-1-git-send-email-yuvalm@mellanox.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 4/4/18 6:24 AM, Yuval Mintz wrote: > Commit 9fd3f0b255d9 ("tc: enable json output for actions") added JSON > support for tc-actions at the expense of breaking other use cases that > reach tc_print_action(), as the latter don't expect the 'actions' array > to be a new object. > > Consider the following taken duringrun of tc_chain.sh selftest, > and see the latter command output is broken: > > $ ./tc/tc -j -p actions list action gact | grep -C 3 actions > [ { > "total acts": 1 > },{ > "actions": [ { > "order": 0, > > $ ./tc/tc -p -j -s filter show dev enp3s0np2 ingress | grep -C 3 actions > }, > "skip_hw": true, > "not_in_hw": true,{ > "actions": [ { > "order": 1, > "kind": "gact", > "control_action": { > > Relocate the open/close of the JSON object to declare the object only > for the case that needs it. > > Signed-off-by: Yuval Mintz > --- > tc/m_action.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) This is a bug fix so it should go through master. Added Roman so he is aware of the mistake.