From: Andrew Lunn <andrew@lunn.ch>
To: Justin Chen <justin.chen@broadcom.com>
Cc: netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
pabeni@redhat.com, kuba@kernel.org, edumazet@google.com,
davem@davemloft.net, andrew+netdev@lunn.ch,
florian.fainelli@broadcom.com
Subject: Re: [PATCH net-next 2/2] net: bcmasp: Keep PHY link during WoL sleep cycle
Date: Wed, 29 Apr 2026 00:23:14 +0200 [thread overview]
Message-ID: <cf941a1d-efe0-4692-b627-2dc529ff2bec@lunn.ch> (raw)
In-Reply-To: <20260428220858.2076469-3-justin.chen@broadcom.com>
On Tue, Apr 28, 2026 at 03:08:58PM -0700, Justin Chen wrote:
> We currently more or less restart all the HW on resume. Since we also
> stop the PHY, it takes a while for the PHY link to be re-negotiated on
> resume.
So you are just interested in getting networking working faster. This
is independent of WoL? Clearly, if you have WoL enabled you need to
keep the PHY powered, but faster networking should be orthogonal to
WoL.
> - bcmasp_netif_deinit(dev);
> + wake = device_may_wakeup(kdev) && intf->wolopts;
>
> - if (!intf->wolopts) {
> + bcmasp_netif_deinit(dev, !wake);
So given your commit message, this i don't understand. For the fast
restarting of networking, it does not matter if WoL is enabled, or if
the PHY is capable of waking the system.
Andrew
next prev parent reply other threads:[~2026-04-28 22:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 22:08 [PATCH 0/2] Keep PHY link during WoL sleep cycle Justin Chen
2026-04-28 22:08 ` [PATCH net-next 1/2] net: bcmasp: Divide init to allow partial bring up Justin Chen
2026-04-29 23:20 ` Jakub Kicinski
2026-04-30 23:24 ` Justin Chen
2026-04-28 22:08 ` [PATCH net-next 2/2] net: bcmasp: Keep PHY link during WoL sleep cycle Justin Chen
2026-04-28 22:23 ` Andrew Lunn [this message]
2026-04-28 23:44 ` Justin Chen
2026-04-29 23:20 ` Jakub Kicinski
2026-04-30 23:02 ` Justin Chen
2026-04-29 0:06 ` [PATCH 0/2] " Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf941a1d-efe0-4692-b627-2dc529ff2bec@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=justin.chen@broadcom.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox