From: Moshe Shemesh <moshe@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>, Moshe Shemesh <moshe@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jiri Pirko <jiri@nvidia.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] devlink: Fix reload stats structure
Date: Mon, 23 Nov 2020 07:19:54 +0200 [thread overview]
Message-ID: <cfa39a4e-e78e-018d-e51a-0a38407af122@nvidia.com> (raw)
In-Reply-To: <20201121145349.3824029c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 11/22/2020 12:53 AM, Jakub Kicinski wrote:
> External email: Use caution opening links or attachments
>
>
> On Fri, 20 Nov 2020 15:40:37 +0200 Moshe Shemesh wrote:
>> Fix reload stats structure exposed to the user. Change stats structure
>> hierarchy to have the reload action as a parent of the stat entry and
>> then stat entry includes value per limit. This will also help to avoid
>> string concatenation on iproute2 output.
>>
>> Reload stats structure before this fix:
>> "stats": {
>> "reload": {
>> "driver_reinit": 2,
>> "fw_activate": 1,
>> "fw_activate_no_reset": 0
>> }
>> }
>>
>> After this fix:
>> "stats": {
>> "reload": {
>> "driver_reinit": {
>> "unspecified": 2
>> },
>> "fw_activate": {
>> "unspecified": 1,
>> "no_reset": 0
>> }
>> }
>>
>> Fixes: a254c264267e ("devlink: Add reload stats")
>> Signed-off-by: Moshe Shemesh <moshe@mellanox.com>
>> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
> At least try to fold the core networking code at 80 characters *please*.
>
> You folded the comments at 86 chars, neither 100 nor 80.
Oh, I missed that comment folding while replacing it in this patch. I
will fix, thanks.
prev parent reply other threads:[~2020-11-23 5:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 13:40 [PATCH net] devlink: Fix reload stats structure Moshe Shemesh
2020-11-21 22:53 ` Jakub Kicinski
2020-11-23 5:19 ` Moshe Shemesh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfa39a4e-e78e-018d-e51a-0a38407af122@nvidia.com \
--to=moshe@nvidia.com \
--cc=davem@davemloft.net \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).