From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAF99C53210 for ; Wed, 4 Jan 2023 20:38:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235502AbjADUiS (ORCPT ); Wed, 4 Jan 2023 15:38:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235450AbjADUiQ (ORCPT ); Wed, 4 Jan 2023 15:38:16 -0500 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4DA514D13 for ; Wed, 4 Jan 2023 12:38:15 -0800 (PST) Received: by mail-lf1-x12c.google.com with SMTP id b3so52175626lfv.2 for ; Wed, 04 Jan 2023 12:38:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rSI6ERH4/Yqp6KxmuUAxEZiVgqcat3iuDxIuYqWqdKI=; b=EUrL1a0g/Z4M8DJK8gyPCoRHCYUJdvMlKtlZ3vc/Udut+zURvRj+MLsdlSIJbLDFcY pqEc8bHBijmPjnZItz7toamQlk396Jht78uZMC5i9Jg/41R0dOBnCUocwcKbCruEVgIU UFL+CRdDiYDW4si0CAaT9+QGqbfwzZpCUlLK7ezBj6IVVI+QTthxrLfnEsiOTQwhT0oE fA+6iNmxW7NcJ2ZFrBfpCxObX+pv5ltxXkPgfw+HSDl0mKA+oU0tId7rjKMTY52aD9Wl 2BgozyiECZGRRwVrf4N2G5YTcPXeIrBwOWOb9p0p8WZfApxO/LicEOPaFamcWzIx0Rin WdXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rSI6ERH4/Yqp6KxmuUAxEZiVgqcat3iuDxIuYqWqdKI=; b=dICHnRmT6A1wwZ2e9BhXIw9qxpwVP1i/vmSeY6B5xJTKa8NQRYYcF3ZIfi7jBvRNSX 4IahTF8bUpFVWWJeYw5mtNsJhbAhyI/NDj/Eaw4M2VLPZtmP9pM04ewFNTBhuaFCY+QC W5FL0hO70vGPqZLM0AL0UsSWgTemSZD5+ZJTgB2uLgortc7w2bWWvSwduPcOZmiwhzBI hiee4V/iBzmZq+weV2yiJ7OXCGyEeqWmLVWkEDMYmd2Q0AHKJ1BWuyC2p3WhHeUVVf+G 9Sx3nhKiL5Wx3WUEQplI2ypU8z740iVQndsLc9rHpA0+WzCRng2rRtGpiGSYX8PRwRxF rxbg== X-Gm-Message-State: AFqh2kpbxkY7p+7G0ldHFfcxqKk0sM2+ne2l72ZvC+RtGGzMGPA9S/Ae XsJrUguXfE12LmvZbXV6md1+PA== X-Google-Smtp-Source: AMrXdXvAMHggpVW13iHfxturF/3y3Rg3rJrgB//nwaDeB+yJh3ItjD9Cpp9ahXwpcd2t4mm8E11X/A== X-Received: by 2002:a05:6512:2393:b0:4a4:68b9:1a00 with SMTP id c19-20020a056512239300b004a468b91a00mr16575061lfv.40.1672864694111; Wed, 04 Jan 2023 12:38:14 -0800 (PST) Received: from [192.168.1.101] (abxi45.neoplus.adsl.tpnet.pl. [83.9.2.45]) by smtp.gmail.com with ESMTPSA id w5-20020ac24425000000b004cb0256116csm4196255lfl.26.2023.01.04.12.38.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 12:38:13 -0800 (PST) Message-ID: Date: Wed, 4 Jan 2023 21:38:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH net-next] net: ipa: correct IPA v4.7 IMEM offset Content-Language: en-US To: Alex Elder , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: luca.weiss@fairphone.com, caleb.connolly@linaro.org, mka@chromium.org, evgreen@chromium.org, andersson@kernel.org, quic_cpratapa@quicinc.com, quic_avuyyuru@quicinc.com, quic_jponduru@quicinc.com, quic_subashab@quicinc.com, elder@kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230104181017.2880916-1-elder@linaro.org> From: Konrad Dybcio In-Reply-To: <20230104181017.2880916-1-elder@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4.01.2023 19:10, Alex Elder wrote: > Commit b310de784bacd ("net: ipa: add IPA v4.7 support") was merged > despite an unresolved comment made by Konrad Dybcio. Konrad > observed that the IMEM region specified for IPA v4.7 did not match > that used downstream for the SM7225 SoC. In "lagoon.dtsi" present > in a Sony Xperia source tree, a ipa_smmu_ap node was defined with a > "qcom,additional-mapping" property that defined the IPA IMEM area > starting at offset 0x146a8000 (not 0x146a9000 that was committed). > > The IPA v4.7 target system used for testing uses the SM7225 SoC, so > we'll adhere what the downstream code specifies is the address of > the IMEM region used for IPA. > > Link: https://lore.kernel.org/linux-arm-msm/20221208211529.757669-1-elder@linaro.org > Tested-by: Luca Weiss > Signed-off-by: Alex Elder > --- Reviewed-by: Konrad Dybcio Konrad > Note: This fixes a commit that first landed in v6.2-rc1. > > drivers/net/ipa/data/ipa_data-v4.7.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ipa/data/ipa_data-v4.7.c b/drivers/net/ipa/data/ipa_data-v4.7.c > index 7552c400961eb..b83390c486158 100644 > --- a/drivers/net/ipa/data/ipa_data-v4.7.c > +++ b/drivers/net/ipa/data/ipa_data-v4.7.c > @@ -357,7 +357,7 @@ static const struct ipa_mem ipa_mem_local_data[] = { > static const struct ipa_mem_data ipa_mem_data = { > .local_count = ARRAY_SIZE(ipa_mem_local_data), > .local = ipa_mem_local_data, > - .imem_addr = 0x146a9000, > + .imem_addr = 0x146a8000, > .imem_size = 0x00002000, > .smem_id = 497, > .smem_size = 0x00009000,