netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Boon@ecsmtp.png.intel.com, Khai@ecsmtp.png.intel.com,
	"Ng <boon.khai.ng"@intel.com,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Boon Khai Ng <boon.khai.ng@intel.com>,
	Shevchenko Andriy <andriy.shevchenko@intel.com>,
	Mun Yew Tham <mun.yew.tham@intel.com>,
	Leong Ching Swee <leong.ching.swee@intel.com>,
	G Thomas Rohan <rohan.g.thomas@intel.com>,
	Shevchenko Andriy <andriy.shevchenko@linux.intel.com>
Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature 2/2] net: stmmac: dwxgmac2: Add support for HW-accelerated VLAN Stripping
Date: Fri, 21 Jul 2023 12:11:25 +0200	[thread overview]
Message-ID: <cfba8fa4-47e5-7553-f40e-9e34b25d1405@kernel.org> (raw)
In-Reply-To: <20230721062617.9810-3-boon.khai.ng@intel.com>

On 21/07/2023 08:26, Boon@ecsmtp.png.intel.com wrote:
> From: Boon Khai Ng <boon.khai.ng@intel.com>
> 
> Currently, VLAN tag stripping is done by software driver in
> stmmac_rx_vlan(). This patch is to Add support for VLAN tag
> stripping by the MAC hardware and MAC drivers to support it.
> This is done by adding rx_hw_vlan() and set_hw_vlan_mode()
> callbacks at stmmac_ops struct which are called from upper
> software layer.
...

>  	if (priv->dma_cap.vlhash) {
>  		ndev->features |= NETIF_F_HW_VLAN_CTAG_FILTER;
>  		ndev->features |= NETIF_F_HW_VLAN_STAG_FILTER;
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index 23d53ea04b24..bd7f3326a44c 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -543,6 +543,12 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac)
>  			plat->flags |= STMMAC_FLAG_TSO_EN;
>  	}
>  
> +	/* Rx VLAN HW Stripping */
> +	if (of_property_read_bool(np, "snps,rx-vlan-offload")) {
> +		dev_info(&pdev->dev, "RX VLAN HW Stripping\n");

Why? Drop.



Best regards,
Krzysztof


       reply	other threads:[~2023-07-21 10:11 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230721062617.9810-1-boon.khai.ng@intel.com>
     [not found] ` <20230721062617.9810-3-boon.khai.ng@intel.com>
2023-07-21 10:11   ` Krzysztof Kozlowski [this message]
2023-07-21 15:30     ` [Enable Designware XGMAC VLAN Stripping Feature 2/2] net: stmmac: dwxgmac2: Add support for HW-accelerated VLAN Stripping Ng, Boon Khai
2023-07-21 15:59       ` Florian Fainelli
2023-07-21 16:12         ` Ng, Boon Khai
2023-07-21 16:29           ` Florian Fainelli
2023-07-21 16:45             ` Ng, Boon Khai
2023-07-21 16:22         ` Krzysztof Kozlowski
2023-07-21 16:22       ` Krzysztof Kozlowski
     [not found] ` <20230721062617.9810-2-boon.khai.ng@intel.com>
2023-07-21 10:10   ` [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-bindings: net: snps,dwmac: Add description for rx-vlan-offload Krzysztof Kozlowski
2023-07-21 15:28     ` Ng, Boon Khai
2023-07-21 16:21       ` Krzysztof Kozlowski
2023-07-21 16:33         ` Ng, Boon Khai
2023-07-22  1:55         ` Jakub Kicinski
2023-07-22  3:32           ` Joe Perches
2023-07-25  1:04             ` Jakub Kicinski
2023-07-25  3:53               ` Joe Perches
2023-07-25  7:33                 ` Geert Uytterhoeven
2023-07-25 13:19                   ` Mario Limonciello
2023-07-25 13:43                     ` Joe Perches
2023-07-25 14:37                       ` Krzysztof Kozlowski
2023-07-25 15:59                         ` [PATCH] scripts: checkpatch: steer people away from using file paths Jakub Kicinski
2023-07-25 16:53                           ` Greg KH
2023-07-25 17:10                             ` Jakub Kicinski
2023-07-25 17:25                               ` Greg KH
2023-07-25 19:52                                 ` Jakub Kicinski
2023-07-25 21:01                                   ` Joe Perches
2023-07-25 16:57                           ` Krzysztof Kozlowski
2023-07-25 21:18                           ` Joe Perches
2023-07-25 22:15                             ` Jakub Kicinski
2023-07-26  6:28                               ` Joe Perches
2023-07-21 16:26       ` [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-bindings: net: snps,dwmac: Add description for rx-vlan-offload Krzysztof Kozlowski
2023-07-21 16:39         ` Ng, Boon Khai
2023-07-21 10:17   ` Shevchenko Andriy
2023-07-21 15:35     ` Ng, Boon Khai
2023-07-21 15:48       ` Shevchenko, Andriy
2023-07-21 15:51         ` Ng, Boon Khai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfba8fa4-47e5-7553-f40e-9e34b25d1405@kernel.org \
    --to=krzk@kernel.org \
    --cc="Ng <boon.khai.ng"@intel.com \
    --cc=Boon@ecsmtp.png.intel.com \
    --cc=Khai@ecsmtp.png.intel.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=boon.khai.ng@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=joabreu@synopsys.com \
    --cc=kuba@kernel.org \
    --cc=leong.ching.swee@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mun.yew.tham@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=peppe.cavallaro@st.com \
    --cc=rohan.g.thomas@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).