From: Emmanuel Deloget <emmanuel.deloget@eho.link>
To: Jakub Kicinski <kuba@kernel.org>, Louis Amas <louis.amas@eho.link>
Cc: Marcin Wojtas <mw@semihalf.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, KP Singh <kpsingh@kernel.org>,
Matteo Croce <mcroce@microsoft.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH v3 net 1/1] net: mvpp2: fix XDP rx queues registering
Date: Mon, 6 Dec 2021 23:14:38 +0100 [thread overview]
Message-ID: <cfd7a6c3-dee9-e0ba-e332-46dc656ba531@eho.link> (raw)
In-Reply-To: <20211206125513.5e835155@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Hello,
On 06/12/2021 21:55, Jakub Kicinski wrote:
> On Mon, 6 Dec 2021 18:22:19 +0100 Louis Amas wrote:
>> The registration of XDP queue information is incorrect because the
>> RX queue id we use is invalid. When port->id == 0 it appears to works
>> as expected yet it's no longer the case when port->id != 0.
>>
>> The problem arised while using a recent kernel version on the
>> MACCHIATOBin. This board has several ports:
>> * eth0 and eth1 are 10Gbps interfaces ; both ports has port->id == 0;
>> * eth2 is a 1Gbps interface with port->id != 0.
>
> Still doesn't apply to net/master [1]. Which tree is it based on?
> Perhaps you are sending this for the BPF tree? [2] Hm, doesn't apply
> there either...
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git/
Strange...
AFAIK the commit was added on top of net/master (as cloned at
approximately 17:30 CET). I'll check with Louis tomorrow morning. We may
have messed-up something.
-- Emmanuel Deloget
next prev parent reply other threads:[~2021-12-06 22:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 17:22 [PATCH v3 net 1/1] net: mvpp2: fix XDP rx queues registering Louis Amas
2021-12-06 20:55 ` Jakub Kicinski
2021-12-06 22:14 ` Emmanuel Deloget [this message]
2021-12-06 22:32 ` Russell King (Oracle)
2021-12-06 22:50 ` Emmanuel Deloget
2021-12-07 14:22 ` Emmanuel Deloget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfd7a6c3-dee9-e0ba-e332-46dc656ba531@eho.link \
--to=emmanuel.deloget@eho.link \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=louis.amas@eho.link \
--cc=mcroce@microsoft.com \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).