From: David Decotigny <david.decotigny@google.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Ian Campbell <ian.campbell@citrix.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Ben Hutchings <bhutchings@solarflare.com>,
Jiri Pirko <jpirko@redhat.com>, Joe Perches <joe@perches.com>,
Szymon Janc <szymon@janc.net.pl>,
Richard Jones <rick.jones2@hp.com>,
Ayaz Abdulla <AAbdulla@nvidia.com>,
David Decotigny <david.decotigny@google.com>
Subject: [PATCH net-next v3 7/9] forcedeth: new ethtool stat counter for TX timeouts
Date: Mon, 14 Nov 2011 16:11:17 -0800 [thread overview]
Message-ID: <cfddaec4b8bdd66e27295a86978af744eae2dd85.1321313729.git.david.decotigny@google.com> (raw)
In-Reply-To: <cover.1321313729.git.david.decotigny@google.com>
In-Reply-To: <cover.1321313729.git.david.decotigny@google.com>
This change publishes a new ethtool stats: tx_timeout that counts the
number of times the tx_timeout callback was triggered.
Signed-off-by: David Decotigny <david.decotigny@google.com>
---
drivers/net/ethernet/nvidia/forcedeth.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c
index 84e8d17..dd24035 100644
--- a/drivers/net/ethernet/nvidia/forcedeth.c
+++ b/drivers/net/ethernet/nvidia/forcedeth.c
@@ -633,6 +633,7 @@ static const struct nv_ethtool_str nv_estats_str[] = {
{ "rx_packets" },
{ "rx_errors_total" },
{ "tx_errors_total" },
+ { "tx_timeout" },
/* version 2 stats */
{ "tx_deferral" },
@@ -673,6 +674,7 @@ struct nv_ethtool_stats {
u64 rx_packets; /* should be ifconfig->rx_packets */
u64 rx_errors_total;
u64 tx_errors_total;
+ u64 tx_timeout;
/* version 2 stats */
u64 tx_deferral;
@@ -852,6 +854,7 @@ struct fe_priv {
struct nv_driver_stat stat_tx_packets; /* not always available in HW */
struct nv_driver_stat stat_tx_bytes;
struct nv_driver_stat stat_tx_dropped;
+ atomic_t stat_tx_timeout; /* TX timeouts since last nv_update_stats */
/* msi/msi-x fields */
u32 msi_flags;
@@ -1746,6 +1749,7 @@ static void nv_update_stats(struct net_device *dev)
NV_DRIVER_STAT_UPDATE_TOTAL(&np->stat_tx_packets);
NV_DRIVER_STAT_UPDATE_TOTAL(&np->stat_tx_bytes);
NV_DRIVER_STAT_UPDATE_TOTAL(&np->stat_tx_dropped);
+ np->estats.tx_timeout += atomic_xchg(&np->stat_tx_timeout, 0);
}
/*
@@ -2639,6 +2643,8 @@ static void nv_tx_timeout(struct net_device *dev)
}
}
+ atomic_inc(&np->stat_tx_timeout);
+
spin_lock_irq(&np->lock);
/* 1) stop tx engine */
--
1.7.3.1
next prev parent reply other threads:[~2011-11-15 0:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 0:11 [PATCH net-next v3 0/9] forcedeth: stats & debug enhancements David Decotigny
2011-11-15 0:11 ` [PATCH net-next v3 1/9] forcedeth: fix stats on hardware without extended stats support David Decotigny
2011-11-15 0:11 ` [PATCH net-next v3 2/9] forcedeth: Add messages to indicate using MSI or MSI-X David Decotigny
2011-11-15 0:11 ` [PATCH net-next v3 3/9] forcedeth: allow to silence "TX timeout" debug messages David Decotigny
2011-11-15 0:11 ` [PATCH net-next v3 4/9] forcedeth: expose module parameters in /sys/module David Decotigny
2011-11-15 0:11 ` [PATCH net-next v3 5/9] forcedeth: implement ndo_get_stats64() API David Decotigny
2011-11-15 1:10 ` Stephen Hemminger
2011-11-15 19:30 ` David Decotigny
2011-11-15 0:11 ` [PATCH net-next v3 6/9] forcedeth: account for dropped RX frames David Decotigny
2011-11-15 0:11 ` David Decotigny [this message]
2011-11-15 0:11 ` [PATCH net-next v3 8/9] forcedeth: stats updated with a deferrable timer David Decotigny
2011-11-15 0:11 ` [PATCH net-next v3 9/9] forcedeth: whitespace/indentation fixes David Decotigny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfddaec4b8bdd66e27295a86978af744eae2dd85.1321313729.git.david.decotigny@google.com \
--to=david.decotigny@google.com \
--cc=AAbdulla@nvidia.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ian.campbell@citrix.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
--cc=szymon@janc.net.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).