Re: [PATCH 1/2] dt-bindings: dp83867: add binding for ti,output-impedance property

[Teresa Remmet <t.remmet@phytec.de>]

Hello Rob,

Am Dienstag, dem 10.02.2026 um 08:48 -0600 schrieb Rob Herring:
> On Thu, Jan 29, 2026 at 03:13:33PM +0100, Teresa Remmet wrote:
> > Add an optional device tree property, "ti,output-impedance", which
> > specifies the output impedance using a raw register field value
> > from
> > 0x0 to 0x1f.
> > 
> > 0x0 corresponds to the highest impedance (approximately 70 ohms),
> > while 0x1f represents the lowest (approximately 35 ohms).
> > 
> > This property allows the impedance to be configured through the
> > device-tree to any required value rather than being limited to
> > fixed
> > minimum or maximum settings.
> > 
> > Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> > ---
> >  Documentation/devicetree/bindings/net/ti,dp83867.yaml | 19
> > ++++++++++++++-----
> >  1 file changed, 14 insertions(+), 5 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> > b/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> > index 4bc1f98fd9fe..a8d8bfb68bee 100644
> > --- a/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> > +++ b/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> > @@ -52,11 +52,20 @@ properties:
> >      description: |
> >        MAC Interface Impedance control to set the programmable
> > output impedance
> >        to a maximum value (70 ohms).
> > -      Note: Specifying an io_impedance_ctrl nvmem cell or one of
> > the
> > -        ti,min-output-impedance, ti,max-output-impedance
> > properties
> > -        are mutually exclusive. If more than one is present, an
> > nvmem
> > -        cell takes precedence over ti,max-output-impedance, which
> > in
> > -        turn takes precedence over ti,min-output-impedance.
> > +      Note: Specifying an io_impedance_ctrl nvmem cell, ti,output-
> > impedance
> > +        or one of the boolean ti,min-output-impedance and ti,max-
> > output-impedance
> > +        properties is mutually exclusive.
> > +        If more than one is present the priority order is nvmem
> > cell,
> > +        ti,output-impedance, ti,max-output-impedance and last
> > +        ti,min-output-impedance.
> > +
> > +  ti,output-impedance:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description:
> > +      MAC Interface Impedance control to set the raw register
> > value from 0x0
> > +      (approx. 70 ohms) to 0x1f (approx. 35 ohms).
> > +    minimum: 0
> > +    maximum: 31
> 
> How does this compare to 'mac-termination-ohms'? Seems like this
> should 
> be a common property whether it's the same or for a different
> location.

the difference is that the termination is not passed in ohms but a raw
register value that can not directly be matched to a resistance value.

The datasheet says here "Output impedance approximate range from 35-
70ohms in 32 steps.
Lowest being 11111 and highest being 00000. Range and Step size
will vary with process."

So using 'mac-termination-ohms' seemed not the right fit here as the
documentation talks about selecting a resistance value which is not
possible in this case.

Teresa

> 
> Rob

-- 
PHYTEC Messtechnik GmbH | Barcelona-Allee 1 | 55129 Mainz, Germany

Geschäftsführer: Dipl.-Ing. Michael Mitezki, Dipl.-Ing. Bodo Huber,
Dipl.-Ing. (FH) Markus Lickes | Handelsregister Mainz HRB 4656 |
Finanzamt Mainz | St.Nr. 26/665/00608, DE 149059855