From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH bpf-next] samples/bpf: fix compilation failure Date: Sat, 22 Sep 2018 03:07:37 +0200 Message-ID: References: <20180920075203.2464-1-bhole_prashant_q7@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Prashant Bhole , Alexei Starovoitov Return-path: Received: from www62.your-server.de ([213.133.104.62]:40536 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725748AbeIVG7J (ORCPT ); Sat, 22 Sep 2018 02:59:09 -0400 In-Reply-To: <20180920075203.2464-1-bhole_prashant_q7@lab.ntt.co.jp> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 09/20/2018 09:52 AM, Prashant Bhole wrote: > following commit: > commit d58e468b1112 ("flow_dissector: implements flow dissector BPF hook") > added struct bpf_flow_keys which conflicts with the struct with > same name in sockex2_kern.c and sockex3_kern.c > > similar to commit: > commit 534e0e52bc23 ("samples/bpf: fix a compilation failure") > we tried the rename it "flow_keys" but it also conflicted with struct > having same name in include/net/flow_dissector.h. Hence renaming the > struct to "flow_key_record". Also, this commit doesn't fix the > compilation error completely because the similar struct is present in > sockex3_kern.c. Hence renaming it in both files sockex3_user.c and > sockex3_kern.c > > Signed-off-by: Prashant Bhole Applied to bpf-next, thanks Prashant!