From: "Kris Katterjohn" <kjak@ispwest.com>
To: "Mitchell Blank Jr" <mitch@sfgoth.com>,
"Patrick McHardy" <kaber@trash.net>
Cc: "Herbert Xu" <herbert@gondor.apana.org.au>,
jschlst@samba.org, davem@davemloft.net, acme@ghostprotocols.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Merge __load_pointer() and load_pointer() in net/core/filter.c;kernel 2.6.14
Date: Thu, 3 Nov 2005 10:13:04 -0800 [thread overview]
Message-ID: <cff2d7595303438db8feb9237d6c835b.kjak@ispwest.com> (raw)
From: Patrick McHardy
> Mitchell Blank Jr wrote:
> > Well the original author presumably thought that the fast-path of
> > load_pointer() was critical enough to keep inline (since it can be run many
> > times per packet) So they made the deliberate choice of separating it
> > into two functions - one inline, one non-inline.
>
> Exactly. __load_pointer is only called rarely, while load_pointer is
> called whenever data needs to be read from the packet. It shouldn't
> be changed without any justification.
That's a good enough answer for me!
Thanks
next reply other threads:[~2005-11-03 18:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-03 18:13 Kris Katterjohn [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-11-03 6:19 [PATCH] Merge __load_pointer() and load_pointer() in net/core/filter.c; kernel 2.6.14 Kris Katterjohn
2005-11-03 6:58 ` Mitchell Blank Jr
2005-11-03 16:19 ` Patrick McHardy
2005-11-03 2:48 Kris Katterjohn
2005-11-03 2:13 Kris Katterjohn
2005-11-03 2:30 ` Herbert Xu
[not found] <e626300280b94e0abc26defcc6043b91.kjak@ispwest.com>
2005-11-03 1:50 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cff2d7595303438db8feb9237d6c835b.kjak@ispwest.com \
--to=kjak@ispwest.com \
--cc=acme@ghostprotocols.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jschlst@samba.org \
--cc=kaber@trash.net \
--cc=kjak@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mitch@sfgoth.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).