From: Neil Horman <nhorman@tuxdriver.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Gao feng <gaofeng@cn.fujitsu.com>, Jiri Bohac <jbohac@suse.cz>
Subject: Re: [RFC] ipv6: rt6_update_expires() seems racy
Date: Tue, 19 Feb 2013 06:30:32 -0500 [thread overview]
Message-ID: <cmysjd5kttdebnlrt28jldw3.1361273432405@email.android.com> (raw)
Thank you Eric! I'll look at this in detail today
Neil
Eric Dumazet <eric.dumazet@gmail.com> wrote:
>Some strange crashes happen in rt6_check_expired(), with access
>to random addresses.
>
>At first glance, it looks like the RTF_EXPIRES and
>stuff added in commit 1716a96101c49186b
>(ipv6: fix problem with expired dst cache)
>are racy : same dst could be manipulated at the same time
>on different cpus.
>
>At some point, our stack believes rt->dst.from contains a dst pointer,
>while its really a jiffie value (as rt->dst.expires shares the same area
>of memory)
>
>rt6_update_expires() should be fixed, or am I missing something ?
>
>CC Neil because of https://bugzilla.redhat.com/show_bug.cgi?id=892060
>
>
>
>
next reply other threads:[~2013-02-19 11:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 11:30 Neil Horman [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-02-18 23:55 [RFC] ipv6: rt6_update_expires() seems racy Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cmysjd5kttdebnlrt28jldw3.1361273432405@email.android.com \
--to=nhorman@tuxdriver.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=gaofeng@cn.fujitsu.com \
--cc=jbohac@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox