netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: re.emese@gmail.com
To: linux-kernel@vger.kernel.org
Cc: Emese Revfy <re.emese@gmail.com>,
	netdev@vger.kernel.org, torvalds@linux-foundation.org,
	davem@davemloft.net
Subject: [PATCH 0/3] constify various _ops structures for net-next-dave-git-a252e7
Date: Mon, 14 Dec 2009 00:59:39 +0100	[thread overview]
Message-ID: <cover.1260707013.git.re.emese@gmail.com> (raw)

From: Emese Revfy <re.emese@gmail.com>

Hello everyone!

The following patch series attempts to constify several structures
that hold function pointers. This is only the initial batch, there
are other candidate structures, some of which can probably be
constified as well, I plan to submit them in the future.

The list of constified structures in this series:
e1000_mac_operations
e1000_phy_operations
e1000_nvm_operations

There are certain exceptions where a given instance of the structure
cannot be const, they are marked with a comment in the patch.

The patches compile fine with an allyesconfig kernel on i386 and x86_64.

Please let me know if any of these structures should not be constified
and any other issues you see with them.


Changelog:
----------
v1 -> v2
	- updated to net-next-dave-git-a252e7
	- extended comments with a reference to code that prevents constification

Thanks,
   Emese

 drivers/net/e1000e/82571.c    |   11 ++++++-----
 drivers/net/e1000e/e1000.h    |    6 +++---
 drivers/net/e1000e/es2lan.c   |    7 ++++---
 drivers/net/e1000e/hw.h       |   18 ++++++++++--------
 drivers/net/e1000e/ich8lan.c  |    6 +++---
 drivers/net/igb/e1000_82575.c |    6 +++---
 drivers/net/igb/e1000_hw.h    |    7 +++++--
 drivers/net/igbvf/vf.h        |    1 +
 8 files changed, 35 insertions(+), 27 deletions(-)

             reply	other threads:[~2009-12-13 23:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-13 23:59 re.emese [this message]
2009-12-13 23:59 ` [PATCH 1/3] Constify struct e1000_mac_operations 2.6.32-git-a252e7 v2 re.emese
2009-12-13 23:59 ` [PATCH 2/3] Constify struct e1000_phy_operations " re.emese
2009-12-13 23:59 ` [PATCH 3/3] Constify struct e1000_nvm_operations " re.emese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1260707013.git.re.emese@gmail.com \
    --to=re.emese@gmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).