From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: [trivial PATCH 00/15] remove duplicate unlikely from IS_ERR Date: Thu, 9 Dec 2010 12:03:53 -0800 Message-ID: References: <1291906801-1389-2-git-send-email-tklauser@distanz.ch> Cc: Jiri Kosina , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org To: netdev@vger.kernel.org, uclinux-dist-devel@blackfin.uclinux.org, rtc-linux@googlegroups.com, linux-s390@vger.kernel.org, osd-dev@open-osd.org, linux-arm-msm@vger.kernel.org, linux- Return-path: In-Reply-To: <1291906801-1389-2-git-send-email-tklauser@distanz.ch> Sender: owner-linux-mm@kvack.org List-Id: netdev.vger.kernel.org Tobias Klauser sent a patch to remove an unnecessary unlikely from drivers/misc/c2port/core.c, https://lkml.org/lkml/2010/12/9/199 Here are the other instances treewide. I think it'd be good if people would, when noticing defects in a specific subsystem, look for and correct the same defect treewide. IS_ERR already has an unlikely test so remove unnecessary unlikelys from the call sites. from: include/linux/err.h #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO) [...] static inline long __must_check IS_ERR(const void *ptr) { return IS_ERR_VALUE((unsigned long)ptr); } Sending directly to maintainers for now, will resend in a month or so only to trivial if not picked up. Joe Perches (15): drm: Remove duplicate unlikely from IS_ERR stmmac: Remove duplicate unlikely from IS_ERR rtc: Remove duplicate unlikely from IS_ERR s390: Remove duplicate unlikely from IS_ERR osd: Remove duplicate unlikely from IS_ERR serial: Remove duplicate unlikely from IS_ERR brcm80211: Remove duplicate unlikely from IS_ERR gadget: Remove duplicate unlikely from IS_ERR exofs: Remove duplicate unlikely from IS_ERR ext2: Remove duplicate unlikely from IS_ERR ext3: Remove duplicate unlikely from IS_ERR ext4: Remove duplicate unlikely from IS_ERR nfs: Remove duplicate unlikely from IS_ERR mm: Remove duplicate unlikely from IS_ERR ipv6: Remove duplicate unlikely from IS_ERR drivers/gpu/drm/ttm/ttm_tt.c | 4 ++-- drivers/net/stmmac/stmmac_main.c | 2 +- drivers/rtc/rtc-bfin.c | 2 +- drivers/s390/scsi/zfcp_fsf.c | 4 ++-- drivers/scsi/osd/osd_initiator.c | 2 +- drivers/serial/msm_serial.c | 2 +- drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c | 2 +- drivers/usb/gadget/f_fs.c | 4 ++-- fs/exofs/super.c | 2 +- fs/ext2/namei.c | 2 +- fs/ext3/namei.c | 2 +- fs/ext4/namei.c | 2 +- fs/nfs/mount_clnt.c | 2 +- mm/vmalloc.c | 2 +- net/ipv6/af_inet6.c | 2 +- 15 files changed, 18 insertions(+), 18 deletions(-) -- 1.7.3.3.464.gf80b6 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: [PATCH 02/15] stmmac: Remove duplicate unlikely from IS_ERR Date: Thu, 9 Dec 2010 12:03:55 -0800 Message-ID: <6ab3aedcd80e5c5b3c67194975082183b6c9bda3.1291923889.git.joe@perches.com> References: <1291906801-1389-2-git-send-email-tklauser@distanz.ch> Cc: Jiri Kosina , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Giuseppe Cavallaro Return-path: In-Reply-To: <1291906801-1389-2-git-send-email-tklauser@distanz.ch> In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org IS_ERR already uses unlikely, remove unlikely from the call sites. Signed-off-by: Joe Perches --- drivers/net/stmmac/stmmac_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/stmmac/stmmac_main.c b/drivers/net/stmmac/stmmac_main.c index c0dc785..20f803d 100644 --- a/drivers/net/stmmac/stmmac_main.c +++ b/drivers/net/stmmac/stmmac_main.c @@ -949,7 +949,7 @@ static int stmmac_sw_tso(struct stmmac_priv *priv, struct sk_buff *skb) skb, skb->len); segs = skb_gso_segment(skb, priv->dev->features & ~NETIF_F_TSO); - if (unlikely(IS_ERR(segs))) + if (IS_ERR(segs)) goto sw_tso_end; do { -- 1.7.3.3.464.gf80b6 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: [PATCH 15/15] ipv6: Remove duplicate unlikely from IS_ERR Date: Thu, 9 Dec 2010 12:04:08 -0800 Message-ID: References: <1291906801-1389-2-git-send-email-tklauser@distanz.ch> Cc: Jiri Kosina , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: "David S. Miller" , Alexey Kuznetsov , "Pekka Savola (ipv6)" , James Morris , Hideaki YOSHIFUJI In-Reply-To: <1291906801-1389-2-git-send-email-tklauser@distanz.ch> In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org IS_ERR already uses unlikely, remove unlikely from the call sites. Signed-off-by: Joe Perches --- net/ipv6/af_inet6.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c index 54e8e42..059a3de 100644 --- a/net/ipv6/af_inet6.c +++ b/net/ipv6/af_inet6.c @@ -810,7 +810,7 @@ static struct sk_buff *ipv6_gso_segment(struct sk_buff *skb, int features) } rcu_read_unlock(); - if (unlikely(IS_ERR(segs))) + if (IS_ERR(segs)) goto out; for (skb = segs; skb; skb = skb->next) { -- 1.7.3.3.464.gf80b6 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [trivial PATCH 00/15] remove duplicate unlikely from IS_ERR Date: Thu, 09 Dec 2010 12:32:53 -0800 Message-ID: <1291926773.20677.26.camel@Joe-Laptop> References: <1291906801-1389-2-git-send-email-tklauser@distanz.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: uclinux-dist-devel@blackfin.uclinux.org, rtc-linux@googlegroups.com, linux-s390@vger.kernel.org, osd-dev@open-osd.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, Jiri Kosina , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org To: netdev@vger.kernel.org, Tobias Klauser Return-path: In-Reply-To: Sender: owner-linux-mm@kvack.org List-Id: netdev.vger.kernel.org On Thu, 2010-12-09 at 12:03 -0800, Joe Perches wrote: > Tobias Klauser sent a patch to remove > an unnecessary unlikely from drivers/misc/c2port/core.c, > https://lkml.org/lkml/2010/12/9/199 It seems that Tobias did send all the appropriate patches, not as a series, but as individual patches to kernel-janitor. c2port was the only one that went to lkml. Please ignore this series and apply Tobias' patches. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org