netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Weiping Pan <panweiping3@gmail.com>
To: fubar@us.ibm.com, andy@greyhouse.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Weiping Pan <panweiping3@gmail.com>
Subject: [PATCH v4 net-next 0/5] bonding:use latest lacp_rate and ad_select,
Date: Thu,  9 Jun 2011 15:03:26 +0800	[thread overview]
Message-ID: <cover.1307601948.git.panweiping3@gmail.com> (raw)

There is bug that when you modify lacp_rate via sysfs,
802.3ad won't use the new value of lacp_rate to transmit packets.
This is because port->actor_oper_port_state isn't changed.

As for ad_select, it can work,
but both struct bond_params and ad_bond_info have lacp_fast and ad_select,
they are duplicate and need extra synchronization.
802.3ad can get them from bond_params directly every time.

And ad_timer and arp_mon_pt aren't used any more, just delete them.

changelog:
v2:
add bond_3ad_update_lacp_rate() as a helper function,
and hold bond->lock when iterates slave list.

v3:
delete duplicate lacp_fast and agg_select_mode from struct ad_bond_info.

v4:
delete unused ad_timer and arp_mon_pt.

Weiping Pan (5):
  bonding: make 802.3ad use latest lacp_rate
  bonding:delete lacp_fast from ad_bond_info
  bonding:delete agg_select_mode from ad_bond_info
  bonding: delete unused ad_timer
  bonding: delete unused arp_mon_pt

 drivers/net/bonding/bond_3ad.c   |   41 ++++++++++++++++++++++++++++++++-----
 drivers/net/bonding/bond_3ad.h   |    8 +-----
 drivers/net/bonding/bond_main.c  |    3 +-
 drivers/net/bonding/bond_sysfs.c |    1 +
 drivers/net/bonding/bonding.h    |    1 -
 5 files changed, 39 insertions(+), 15 deletions(-)

-- 
1.7.4.4

             reply	other threads:[~2011-06-09  7:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-09  7:03 Weiping Pan [this message]
2011-06-09  7:03 ` [PATCH net-next 1/5] bonding: make 802.3ad use latest lacp_rate Weiping Pan
2011-06-09  7:03 ` [PATCH net-next 2/5] bonding:delete lacp_fast from ad_bond_info Weiping Pan
2011-06-09  7:03 ` [PATCH net-next 3/5] bonding:delete agg_select_mode " Weiping Pan
2011-06-09  7:03 ` [PATCH net-next 4/5] bonding: delete unused ad_timer Weiping Pan
2011-06-09  7:03 ` [PATCH net-next 5/5] bonding: delete unused arp_mon_pt Weiping Pan
2011-06-09  7:13 ` [PATCH v4 net-next 0/5] bonding:use latest lacp_rate and ad_select, WeipingPan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1307601948.git.panweiping3@gmail.com \
    --to=panweiping3@gmail.com \
    --cc=andy@greyhouse.net \
    --cc=fubar@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).