netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Decotigny <david.decotigny@google.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Ian Campbell <ian.campbell@citrix.com>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	Ben Hutchings <bhutchings@solarflare.com>,
	Jiri Pirko <jpirko@redhat.com>, Joe Perches <joe@perches.com>,
	Szymon Janc <szymon@janc.net.pl>,
	Richard Jones <rick.jones2@hp.com>,
	Ayaz Abdulla <AAbdulla@nvidia.com>,
	David Decotigny <david.decotigny@google.com>
Subject: [PATCH net-next v6 0/9] net-sysfs+forcedeth: stats & debug enhancements
Date: Wed, 16 Nov 2011 14:15:06 -0800	[thread overview]
Message-ID: <cover.1321481064.git.david.decotigny@google.com> (raw)

These changes provide a new generic network tx_timeout sysfs queue
attribute and implement the ndo_get_stats64 API for forcedeth. They
also add a few more stats and debugging features for forcedeth. They
ensure that stats updates are correct in SMP systems, 32 or 64-bits.

Thanks to all the reviewers of the previous versions of this series!

Note: patch 1 is the cherry-pick of 898bdf2cb43e ("forcedeth: fix
stats on hardware without extended stats support")

Changes since v5:
  - get_stats64: back to using u64_stats_sync.h instead of atomic
    integers, but this time with 2 seqcounts: one for TX, one for RX

Changes since v4:
  - tx_timeout counter now a generic sysfs attribute. Credits to
    Stephen Hemminger for initial implementation
  - revert get_stats64 to using atomic variables: see
    http://patchwork.ozlabs.org/patch/125861/ for motivations
  - dropped patch "expose module parameters in /sys/module" for now: I
    will work on this later, following Stephen's recommendations
    (http://patchwork.ozlabs.org/patch/125862/).

Changes since v3:
  - updated get_stats64 + rx_dropped patches to use u64_stats_sync.h
  - dropped indentation "whitespace/indentation fixes" (included in
    get_stats64 api patch)

Changes since v2:
  - patch 1/9 is the cherry-pick of 898bdf2cb43e ("forcedeth: fix
    stats on hardware without extended stats support")
  - removed patch 5/10 "stats for rx_packets based on hardware
    registers" because packets&bytes stats are updated in software
    only (898bdf2cb43e)

Changes since v1:
  - patch 1/10 is the same as
    http://patchwork.ozlabs.org/patch/125017/ (targetting net)
  - other patches updated to take patch 1/10 into account
  - various commit message updates


Tested:
  ~150Mbps incoming TCP, ethtool -S in a loop, x86_64 16-way:
     tx_bytes: 5441989419
     rx_packets: 5439224
     tx_timeout: 0
     tx_packets: 5456705
     rx_bytes: 5566763850

Tested:
  pktgen + loopback report same RX/TX packets and bytes stats

Tested:
  tests above with Kconfig DEBUG_PAGEALLOC DEBUG_MUTEXES
  DEBUG_SPINLOCK LOCKUP_DETECTOR DEBUG_RT_MUTEXES DEBUG_LOCK_ALLOC
  PROVE_LOCKING DEBUG_ATOMIC_SLEEP DEBUG_STACK_USAGE DEBUG_KOBJECT
  DEBUG_VM DEBUG_LIST DEBUG_SG DEBUG_NOTIFIERS TEST_KSTRTOX
  STRICT_DEVMEM DEBUG_STACKOVERFLOW


############################################
# Patch Set Summary:

David Decotigny (6):
  net-sysfs: fixed minor sparse warning
  kbuild: document RPS/XPS network Kconfig options
  net: new counter for tx_timeout errors in sysfs
  forcedeth: implement ndo_get_stats64() API
  forcedeth: account for dropped RX frames
  forcedeth: stats updated with a deferrable timer

Mike Ditto (1):
  forcedeth: Add messages to indicate using MSI or MSI-X

Sameer Nanda (1):
  forcedeth: allow to silence "TX timeout" debug messages

david decotigny (1):
  forcedeth: fix stats on hardware without extended stats support

 drivers/net/ethernet/nvidia/forcedeth.c |  321 ++++++++++++++++++++++---------
 include/linux/netdevice.h               |   12 +-
 net/Kconfig                             |   22 ++-
 net/core/net-sysfs.c                    |   49 ++++--
 net/sched/sch_generic.c                 |    1 +
 5 files changed, 296 insertions(+), 109 deletions(-)

-- 
1.7.3.1

             reply	other threads:[~2011-11-16 22:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-16 22:15 David Decotigny [this message]
2011-11-16 22:15 ` [PATCH net-next v6 1/9] forcedeth: fix stats on hardware without extended stats support David Decotigny
2011-11-16 22:15 ` [PATCH net-next v6 2/9] net-sysfs: fixed minor sparse warning David Decotigny
2011-11-16 22:15 ` [PATCH net-next v6 3/9] kbuild: document RPS/XPS network Kconfig options David Decotigny
2011-11-16 23:12   ` Ben Hutchings
2011-11-17  1:54     ` David Decotigny
2011-11-17  2:54       ` Ben Hutchings
2011-11-17  2:59         ` David Miller
2011-11-17  3:19           ` Eric Dumazet
2011-11-16 22:15 ` [PATCH net-next v6 4/9] net: new counter for tx_timeout errors in sysfs David Decotigny
2011-11-16 22:15 ` [PATCH net-next v6 5/9] forcedeth: Add messages to indicate using MSI or MSI-X David Decotigny
2011-11-16 22:15 ` [PATCH net-next v6 6/9] forcedeth: allow to silence "TX timeout" debug messages David Decotigny
2011-11-16 22:15 ` [PATCH net-next v6 7/9] forcedeth: implement ndo_get_stats64() API David Decotigny
2011-11-17  6:34   ` Eric Dumazet
2011-11-17 17:39     ` David Decotigny
2011-11-17 17:47       ` Eric Dumazet
2011-11-16 22:15 ` [PATCH net-next v6 8/9] forcedeth: account for dropped RX frames David Decotigny
2011-11-16 22:15 ` [PATCH net-next v6 9/9] forcedeth: stats updated with a deferrable timer David Decotigny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1321481064.git.david.decotigny@google.com \
    --to=david.decotigny@google.com \
    --cc=AAbdulla@nvidia.com \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=ian.campbell@citrix.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=joe@perches.com \
    --cc=jpirko@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rick.jones2@hp.com \
    --cc=szymon@janc.net.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).