netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Eaglesham <linux@8192.net>
To: netdev@vger.kernel.org
Cc: John Eaglesham <linux@8192.net>
Subject: [PATCH v4 0/2] bonding support for IPv6 transmit hashing
Date: Sun,  1 Jul 2012 00:01:37 -0700	[thread overview]
Message-ID: <cover.1341125875.git.linux@8192.net> (raw)

Currently the "bonding" driver does not support load balancing outgoing
traffic in LACP mode for IPv6 traffic. IPv4 (and TCP or UDP over IPv4)
are currently supported; this patch adds transmit hashing for IPv6 (and
TCP or UDP over IPv6), bringing IPv6 up to par with IPv4 support in the
bonding driver.

The algorithm chosen (xor'ing the bottom three quads and then xor'ing
the bottom three bytes of that) was chosen after testing almost 400,000
unique IPv6 addresses harvested from server logs. This algorithm had the
most even distribution for both big- and little-endian architectures while
still using few instructions.

The IPv6 flow label was intentionally not included in the hash as it appears
to be unset in the vast majority of IPv6 traffic sampled, and the current
algorithm not using the flow label already offers a very even distribution.

Fragmented IPv6 packets are handled the same way as fragmented IPv4 packets,
ie, they are not balanced based on layer 4 information. Additionally,
IPv6 packets with intermediate headers are not balanced based on layer
4 information. In practice these intermediate headers are not common and
this should not cause any problems, and the alternative (a packet-parsing
loop and look-up table) seemed slow and complicated for little gain.

This is an update to a prior patch I submitted. This version includes
a clarified description, thorough bounds checking, updates functions to
call bond_xmit_hash_policy_l2 rather than re-implement the same logic,
incorporates Jay's style suggestions, and patches against net-next. Patch
has been tested and performs as expected.

John Eaglesham (2):
  Add support for IPv6 and bounds checking to transmit hashing
    functions.
  Update bonding driver documentation to include IPv6 transmit hashing
    algorithm.

 Documentation/networking/bonding.txt | 31 ++++++++++--
 drivers/net/bonding/bond_main.c      | 91 +++++++++++++++++++++++++-----------
 2 files changed, 90 insertions(+), 32 deletions(-)

-- 
1.7.11

             reply	other threads:[~2012-07-01  7:02 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-01  7:01 John Eaglesham [this message]
2012-07-01  7:01 ` [PATCH v4 1/2] Add support for IPv6 and bounds checking to transmit hashing functions John Eaglesham
2012-07-01  7:33   ` David Miller
2012-07-01  7:01 ` [PATCH v4 2/2] Update bonding driver documentation to include IPv6 transmit hashing algorithm John Eaglesham
2012-07-01  7:34   ` David Miller
2012-07-01  7:42     ` John Eaglesham
2012-07-01  8:07 ` [PATCH v5] bonding support for IPv6 transmit hashing John Eaglesham
2012-07-01 10:33   ` David Miller
2012-07-01 19:01     ` John Eaglesham
2012-07-01 19:13   ` [PATCH v6] " John Eaglesham
2012-07-02 23:33     ` Jay Vosburgh
2012-07-03  5:01       ` John Eaglesham
2012-07-03  5:14         ` David Miller
2012-07-03  5:38           ` John Eaglesham
2012-07-03  5:43             ` David Miller
2012-08-21 18:11               ` Jeremy Brookman
2012-08-21 19:19                 ` Jay Vosburgh
2012-08-21 22:21                   ` John Eaglesham
2012-08-22 12:06                     ` Jeremy Brookman
2012-08-23 10:42                   ` Jeremy Brookman
2012-08-22  5:12     ` [PATCH v7] bonding: " John Eaglesham
2012-08-22  5:29       ` David Miller
2012-08-22  6:43       ` [PATCH v8] " John Eaglesham
2012-08-23  5:49         ` David Miller
2012-08-23 12:23         ` Jeremy Brookman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1341125875.git.linux@8192.net \
    --to=linux@8192.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).