netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Kubecek <mkubecek@suse.cz>
To: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
	netdev@vger.kernel.org, Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	James Morris <jmorris@namei.org>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	Patrick McHardy <kaber@trash.net>
Subject: [PATCH net v2 0/2] ipv6: prevent fib6_run_gc() contention
Date: Thu,  1 Aug 2013 10:04:04 +0200 (CEST)	[thread overview]
Message-ID: <cover.1375343204.git.mkubecek@suse.cz> (raw)

On a high-traffic router with many processors and many IPv6 dst entries,
soft lockup in fib6_run_gc() can occur when number of entries reaches
gc_thresh. Prevent this by not waiting for the lock if garbage collector
is already running as we would only run it again as soon as it finished.

v2: as suggested by Eric Dumazet, move update of ip6_rt_last_gc into
    fib6_run_gc() so that it reflects every run of garbage collector
    rather than only those via ip6_dst_gc()

Michal Kubecek (2):
  ipv6: prevent fib6_run_gc() contention
  ipv6: update ip6_rt_last_gc every time GC is run

 include/net/ip6_fib.h |  2 +-
 net/ipv6/ip6_fib.c    | 25 +++++++++++++------------
 net/ipv6/ndisc.c      |  4 ++--
 net/ipv6/route.c      |  8 +++-----
 4 files changed, 19 insertions(+), 20 deletions(-)

-- 
1.8.1.4

             reply	other threads:[~2013-08-01  8:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-01  8:04 Michal Kubecek [this message]
2013-08-01  8:04 ` [PATCH net v2 1/2] ipv6: prevent fib6_run_gc() contention Michal Kubecek
2013-08-01  8:04 ` [PATCH net v2 2/2] ipv6: update ip6_rt_last_gc every time GC is run Michal Kubecek
2013-08-01 21:18 ` [PATCH net v2 0/2] ipv6: prevent fib6_run_gc() contention David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1375343204.git.mkubecek@suse.cz \
    --to=mkubecek@suse.cz \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).