From: Andy Lutomirski <luto@amacapital.net>
To: "Eric W. Biederman" <ebiederm@xmission.com>, security@kernel.org
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Andy Lutomirski <luto@amacapital.net>
Subject: [PATCH 0/2] Rename nsproxy.pid_ns and fix a related security bug
Date: Thu, 22 Aug 2013 11:39:14 -0700 [thread overview]
Message-ID: <cover.1377196394.git.luto@amacapital.net> (raw)
In:
commit 92f28d973cce45ef5823209aab3138eb45d8b349
Author: Eric W. Biederman <ebiederm@xmission.com>
Date: Fri Mar 15 01:03:33 2013 -0700
scm: Require CAP_SYS_ADMIN over the current pidns to spoof pids.
Eric fell for my bogus claim that nsproxy->pid_ns was the current'
process's pid ns. This isn't true.
Let's fix the bug and rename pid_ns so that no one gets this wrong again.
Signed-off-by: Andy Lutomirski <luto@amacapital.net>
Andy Lutomirski (2):
net: Check the correct namespace when spoofing pid over SCM_RIGHTS
Rename nsproxy.pid_ns to nsproxy.pid_ns_for_children
include/linux/nsproxy.h | 6 +++++-
kernel/fork.c | 5 +++--
kernel/nsproxy.c | 27 ++++++++++++++-------------
kernel/pid_namespace.c | 4 ++--
net/core/scm.c | 2 +-
5 files changed, 25 insertions(+), 19 deletions(-)
--
1.8.3.1
next reply other threads:[~2013-08-22 18:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 18:39 Andy Lutomirski [this message]
2013-08-22 18:39 ` [PATCH 1/2] net: Check the correct namespace when spoofing pid over SCM_RIGHTS Andy Lutomirski
2013-08-27 1:02 ` Eric W. Biederman
2013-08-22 18:39 ` [PATCH 2/2] Rename nsproxy.pid_ns to nsproxy.pid_ns_for_children Andy Lutomirski
2013-08-22 18:56 ` Oleg Nesterov
2013-08-27 1:02 ` Eric W. Biederman
2013-08-26 19:59 ` [PATCH 0/2] Rename nsproxy.pid_ns and fix a related security bug David Miller
2013-08-27 1:03 ` Eric W. Biederman
2013-08-27 17:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1377196394.git.luto@amacapital.net \
--to=luto@amacapital.net \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).